Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different points ID will have the same ID after inserting to qdrant #3170

Closed
golangboy opened this issue Dec 6, 2023 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@golangboy
Copy link
Contributor

Current Behavior

There are two points with same ID.

{
  "result": {
    "points": [
      {
        "id": 1000001001111123100,
        "payload": {
          "name": "test122"
        },
        "vector": null
      },
      {
        "id": 1000001001111123100,
        "payload": {
          "name": "test12"
        },
        "vector": null
      }
    ],
    "next_page_offset": null
  },
  "status": "ok",
  "time": 0.000893462
}

Steps to Reproduce

import qdrant_client
from qdrant_client import QdrantClient
from qdrant_client.http.models import Distance, VectorParams, PointStruct

client = QdrantClient("10.131.7.124", port=6333)
client.create_collection(
    collection_name="test",
    vectors_config=VectorParams(size=4, distance=Distance.DOT),
)
client.upsert(
    collection_name="test",
    points=[
        PointStruct(
            id=1000001001111123112,
            vector=[1.0, 2.0, 3.0, 4.0],
            payload={"name": "test12"},
        ),
    ],
    wait=False,
)

client.upsert(
    collection_name="test",
    points=[
        PointStruct(
            id=1000001001111123111,
            vector=[1.0, 2.0, 3.0, 40.0],
            payload={"name": "test122"},
        ),
    ],
    wait=False,
)

Expected Behavior

A point's ID is 1000001001111123112, and another points's ID is 1000001001111123111.

Possible Solution

Not obligatory, but suggest a fix/reason for the bug

Context (Environment)

Qdrant v1.6.1

Detailed Description

Provide a detailed description of the change or addition you are proposing

Possible Implementation

Not obligatory, but suggest an idea for implementing addition or change

@golangboy golangboy added the bug Something isn't working label Dec 6, 2023
@golangboy golangboy changed the title If point with given ID already exists - it will not be overwritten.!!!! Different points ID will have the same ID after inserting to qdrant Dec 6, 2023
@timvisee
Copy link
Member

timvisee commented Dec 6, 2023

Question, what client are you using? Is it the JavaScript/TypeScript client by any chance?

@golangboy
Copy link
Contributor Author

golangboy commented Dec 6, 2023

Question, what client are you using? Is it the JavaScript/TypeScript client by any chance?

client: https://github.com/qdrant/qdrant-web-ui

and open the url:

http://127.0.0.1:6333/dashboard#/console

and run the post request!

POST collections/test/points/scroll
{
  "limit": 10,
  "filter": {
    "must": [
      {
     
      }
    ]
  }
}

@golangboy
Copy link
Contributor Author

@timvisee maybe it is client' problem,because i post the request with postman, anything is ok!
this is the response!

{
    "result": {
        "points": [
            {
                "id": 1000001001111123111,
                "payload": {
                    "name": "test122"
                },
                "vector": null
            },
            {
                "id": 1000001001111123112,
                "payload": {
                    "name": "test12"
                },
                "vector": null
            }
        ],
        "next_page_offset": null
    },
    "status": "ok",
    "time": 0.0740577
}

@golangboy
Copy link
Contributor Author

conclusion:the response of qdrant is right! the client display the error ID

@golangboy
Copy link
Contributor Author

ok, i found it at qdrant/qdrant-web-ui#87

@timvisee
Copy link
Member

timvisee commented Dec 8, 2023

Wanted to point you to that issue indeed (qdrant/qdrant-web-ui#87).

It's an annoying issue, but we should still take care of it. As you've likely figured out, our other clients (other than JavaScript) don't have this problem.

@timvisee timvisee closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants