-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid pickling of cached values of cached_method
decorated functions
#6674
Labels
kind/bug-report
Something doesn't seem to work.
triage/accepted
there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
Comments
dstrain115
added
the
triage/accepted
there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
label
Jul 24, 2024
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this issue
Jul 25, 2024
Partially resolves quantumlib#6674
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this issue
Aug 8, 2024
ProjectorSum stores data in a mutable LinearDict which is not hashable. LinearDict also does not pickle, because by default it has a lambda-function attribute. This excludes ProjectorSum from the `test_hash_from_pickle` test. Resolves quantumlib#6674
pavoljuhas
added a commit
that referenced
this issue
Aug 8, 2024
ProjectorSum stores data in a mutable LinearDict which is not hashable. LinearDict also does not pickle, because by default it has a lambda-function attribute. This excludes ProjectorSum from the `test_hash_from_pickle` test. Resolves #6674
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this issue
Oct 31, 2024
…b#6677) Ensure cirq objects passed as pickles in multiprocessing calls work consistently in dictionaries just as the in-process created objects. Partially resolves quantumlib#6674
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this issue
Oct 31, 2024
ProjectorSum stores data in a mutable LinearDict which is not hashable. LinearDict also does not pickle, because by default it has a lambda-function attribute. This excludes ProjectorSum from the `test_hash_from_pickle` test. Resolves quantumlib#6674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug-report
Something doesn't seem to work.
triage/accepted
there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
Description of the issue
For some gates, e.g., cirq.H, the
hash(gate)
value is stored with cached_method decorator which breaks dictionary lookup if such gate is passed to multiprocessing worker. This seems to be the root cause for dictionary lookup problem in #6667 (comment).How to reproduce the issue
Output
Proposed solution
Do not pickle cached values from cached_method calls. Arguments to multiprocessing workers are passed as pickles so the results of cached methods (and of
hash(cirq.H)
) would be computed on the worker side.Similar to #3777 and #5738
Cirq version
You can get the cirq version by printing
cirq.__version__
. From the command line:1.5.0.dev at 8d09a32
The text was updated successfully, but these errors were encountered: