Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

equal_up_to_global_phase on gates doesn't work as expected #6574

Open
babacry opened this issue Apr 24, 2024 · 0 comments · May be fixed by #6950
Open

equal_up_to_global_phase on gates doesn't work as expected #6574

babacry opened this issue Apr 24, 2024 · 0 comments · May be fixed by #6950
Assignees
@babacry
Labels
kind/bug-report Something doesn't seem to work. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@babacry
Copy link
Collaborator

babacry commented Apr 24, 2024 •
edited
Loading

Description of the issue
Test cases

        (
            cirq.PhasedXPowGate(phase_exponent=1.5, exponent=1.0),
            cirq.PhasedXPowGate(phase_exponent=0.5, exponent=1.0),
            True,
        ),
        (cirq.XPowGate(exponent=2.0), cirq.I, True),

should pass the test suite IIUC?

If I apply equal_up_to_global_phase to matrices of gates, the test can pass:

cirq.equal_up_to_global_phase(cirq.PhasedXPowGate(phase_exponent=1.5, exponent=1.0),cirq.PhasedXPowGate(phase_exponent=0.5, exponent=1.0))

-> False

cirq.equal_up_to_global_phase(cirq.unitary(cirq.PhasedXPowGate(phase_exponent=1.5, exponent=1.0)),cirq.unitary(cirq.PhasedXPowGate(phase_exponent=0.5, exponent=1.0)))

-> True

How to reproduce the issue

Run the test cases above.

Cirq version

1.4.0.dev
@babacry babacry added the kind/bug-report Something doesn't seem to work. label Apr 24, 2024
@NoureldinYosri NoureldinYosri added the triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on label May 8, 2024
@dstrain115 dstrain115 linked a pull request Jan 14, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@babacry babacry

Labels
kind/bug-report Something doesn't seem to work. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a default fallback for the equal_up_to_global_phase protocol dstrain115/Cirq-1
2 participants
@NoureldinYosri @babacry