We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description of the issue
global phase should be multiplied by the exponent and normalized when comparing eigen gates.
How to reproduce the issue
https://github.com/quantumlib/Cirq/blob/main/cirq-core/cirq/ops/common_gates_test.py#L247-L249 has ZPowGate(phase=-0.5)**5, and https://github.com/quantumlib/Cirq/blob/main/cirq-core/cirq/ops/common_gates_test.py#L252 has a ZPowGate(phase=-0.1)**5 in a different equality group. These are equal gates with the same unitary though, and should be in the same equality group. In the first, the exponentiated phase causes a -5/4 rotation, and in the second it causes a -1/4 rotation, so both end up at the same spot.
ZPowGate(phase=-0.5)**5
ZPowGate(phase=-0.1)**5
Unitaries:
[[0-1j 0+0j] [0+0j 0+1j]] [[0-1j 0+0j] [0+0j 0+1j]]
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Description of the issue
global phase should be multiplied by the exponent and normalized when comparing eigen gates.
How to reproduce the issue
https://github.com/quantumlib/Cirq/blob/main/cirq-core/cirq/ops/common_gates_test.py#L247-L249 has
ZPowGate(phase=-0.5)**5
, and https://github.com/quantumlib/Cirq/blob/main/cirq-core/cirq/ops/common_gates_test.py#L252 has aZPowGate(phase=-0.1)**5
in a different equality group. These are equal gates with the same unitary though, and should be in the same equality group. In the first, the exponentiated phase causes a -5/4 rotation, and in the second it causes a -1/4 rotation, so both end up at the same spot.Unitaries:
The text was updated successfully, but these errors were encountered: