From 1375251f147d7f9417be8f41181c8b4e3b9f7e3a Mon Sep 17 00:00:00 2001 From: Julia Silge Date: Tue, 18 Feb 2025 14:05:44 -0700 Subject: [PATCH] Add `allowIncomplete` to `runtime.executeCode()` (#664) * Add `allowIncomplete` to `runtime.executeCode()` * Update changelog --- apps/vscode/CHANGELOG.md | 1 + apps/vscode/src/@types/hooks.d.ts | 3 ++- apps/vscode/src/host/hooks.ts | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/vscode/CHANGELOG.md b/apps/vscode/CHANGELOG.md index cfce78e4..94c9d057 100644 --- a/apps/vscode/CHANGELOG.md +++ b/apps/vscode/CHANGELOG.md @@ -3,6 +3,7 @@ ## 1.119.0 (unreleased) - Use `QUARTO_VISUAL_EDITOR_CONFIRMED` > `PW_TEST` > `CI` to bypass (`true`) or force (`false`) the Visual Editor confirmation dialogue (). +- Fix behavior in Positron when running a cell containing invalid/incomplete code (). ## 1.118.0 (Release on 2024-11-26) diff --git a/apps/vscode/src/@types/hooks.d.ts b/apps/vscode/src/@types/hooks.d.ts index 8efba98e..16a248fd 100644 --- a/apps/vscode/src/@types/hooks.d.ts +++ b/apps/vscode/src/@types/hooks.d.ts @@ -16,7 +16,8 @@ declare module 'positron' { executeCode( languageId: string, code: string, - focus: boolean + focus: boolean, + allowIncomplete: boolean ): Thenable; } diff --git a/apps/vscode/src/host/hooks.ts b/apps/vscode/src/host/hooks.ts index 3b0b6965..50502c30 100644 --- a/apps/vscode/src/host/hooks.ts +++ b/apps/vscode/src/host/hooks.ts @@ -74,7 +74,7 @@ export function hooksExtensionHost(): ExtensionHost { // Our callback executes each block sequentially const callback = async () => { for (const block of blocks) { - await runtime.executeCode(language, block, false); + await runtime.executeCode(language, block, false, true); } }