Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable contracts to bid for shares during a contract IPO via QPI function(s) #297

Merged
merged 4 commits into from
Feb 6, 2025
Merged

feat: enable contracts to bid for shares during a contract IPO via QPI function(s) #297

merged 4 commits into from
Feb 6, 2025

Conversation

TakaYuPP
Copy link
Contributor

@TakaYuPP TakaYuPP commented Feb 5, 2025

The any contract can bid on IPO for new SC using qpi.bidOnIPO() function.

@TakaYuPP TakaYuPP changed the title feat: added bidOnIPO() function to qpi.h to be available to participate in IPO for new SC feat: enable contracts to bid for shares during a contract IPO via QPI function(s) Feb 5, 2025
philippwerner
philippwerner requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@philippwerner philippwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please address the following comments.

@philippwerner philippwerner linked an issue Feb 6, 2025 that may be closed by this pull request
Enable contracts to bid for shares during a contract IPO via QPI function(s) #293
Open
philippwerner
philippwerner requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@philippwerner philippwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick revision. I have a few additional requests.

philippwerner
philippwerner approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@philippwerner philippwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. I will merge it.

@philippwerner philippwerner merged commit 9d30210 into qubic:develop Feb 6, 2025
1 check passed
@Bertiger Bertiger assigned Bertiger and unassigned Bertiger Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippwerner philippwerner philippwerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
qubic
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable contracts to bid for shares during a contract IPO via QPI function(s)
3 participants
@TakaYuPP @philippwerner @Bertiger