-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getNodeIpList crashes #13
Comments
Another issue with Line 103 in 3a10e27
Issue:Crashes upon log, because hex is not null-terminated. Reproduction
Possible fix:char hex[65];
hex[64] = '\0'; At first I just wanted to just open an issue, because I didn't see a point in an MR for 1 line, but maybe I will make an MR if I run into more stuff. |
Also a null-termination bug in parsing the seed from a config file. Line:Line 167 in 3a10e27
Possible fix:g_seed = (char*)malloc(56);
memset(g_seed, 0, 56); |
Merge Release/ep84 to main (v1.181.0)
Hi, not sure what this line is trying to achieve, but it crashes my application when querying a node ip list.
qubic-cli/nodeUtils.cpp
Line 1054 in 3a10e27
You can reproduce it with the following command:
qubic-cli.exe -nodeip "62.2.98.74" -getnodeiplist
Possible fix:
Simply removing the above line.
The text was updated successfully, but these errors were encountered: