FIXME: why remove this unreachable?

androm3da · androm3da · commit 23deaa431ccb · 2025-02-09T07:49:23.000-08:00
Signed-off-by: Brian Cain &lt;brian.cain@oss.qualcomm.com&gt;
diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c
@@ -489,7 +489,6 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t encoding)
             insn->iclass = iclass_bits(encoding);
             return 1;
         }
-        g_assert_not_reached();
     } else {
         uint32_t iclass = get_duplex_iclass(encoding);
         unsigned int slot0_subinsn = get_slot0_subinsn(encoding);
@@ -512,6 +511,11 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t encoding)
         }
         g_assert_not_reached();
     }
+    /*
+     * invalid/unrecognized opcode; return 1 and let gen_insn() raise an
+     * exception when it sees this empty insn.
+     */
+    return 1;
 }
 
 static void decode_add_endloop_insn(Insn *insn, int loopnum)

Original file line number	Diff line number	Diff line change
`@@ -489,7 +489,6 @@ decode_insns(DisasContext ctx, Insn insn, uint32_t encoding)`
`489`	`489`	`insn->iclass = iclass_bits(encoding);`
`490`	`490`	`return 1;`
`491`	`491`	`}`
`492`		`- g_assert_not_reached();`
`493`	`492`	`} else {`
`494`	`493`	`uint32_t iclass = get_duplex_iclass(encoding);`
`495`	`494`	`unsigned int slot0_subinsn = get_slot0_subinsn(encoding);`
`@@ -512,6 +511,11 @@ decode_insns(DisasContext ctx, Insn insn, uint32_t encoding)`
`512`	`511`	`}`
`513`	`512`	`g_assert_not_reached();`
`514`	`513`	`}`
	`514`	`+ /*`
	`515`	`+ * invalid/unrecognized opcode; return 1 and let gen_insn() raise an`
	`516`	`+ * exception when it sees this empty insn.`
	`517`	`+ */`
	`518`	`+ return 1;`
`515`	`519`	`}`
`516`	`520`
`517`	`521`	`static void decode_add_endloop_insn(Insn *insn, int loopnum)`