Fix Valgrind warning (#1163)

bnoordhuis · web-flow · commit e627e375ea79 · 2025-09-26T22:16:24.000+02:00
Zero-terminate the result buffer after number conversion. Fixes: #1162
diff --git a/quickjs.c b/quickjs.c
@@ -3521,7 +3521,10 @@ static JSAtom js_atom_concat_str(JSContext *ctx, JSAtom name, const char *str1)
 static JSAtom js_atom_concat_num(JSContext *ctx, JSAtom name, uint32_t n)
 {
     char buf[16];
-    u32toa(buf, n);
+    size_t len;
+
+    len = u32toa(buf, n);
+    buf[len] = '\0';
     return js_atom_concat_str(ctx, name, buf);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -3521,7 +3521,10 @@ static JSAtom js_atom_concat_str(JSContext ctx, JSAtom name, const char str1)`
`3521`	`3521`	`static JSAtom js_atom_concat_num(JSContext *ctx, JSAtom name, uint32_t n)`
`3522`	`3522`	`{`
`3523`	`3523`	`char buf[16];`
`3524`		`- u32toa(buf, n);`
	`3524`	`+ size_t len;`
	`3525`	`+`
	`3526`	`+ len = u32toa(buf, n);`
	`3527`	`+ buf[len] = '\0';`
`3525`	`3528`	`return js_atom_concat_str(ctx, name, buf);`
`3526`	`3529`	`}`
`3527`	`3530`