Skip to content

Commit 56521e2

Browse files
nicolearagaoinfinitewarp
authored andcommitted
refactor: bump QPC_MIN_SERVER_VERSION to 2.5.0
Remove per-subcommand min_server_version overrides from report deployments, details, download, and insights commands. Mixing old and new server/client is not supported, so all commands should use the single global QPC_MIN_SERVER_VERSION. Bump it from 2.4.0 to 2.5.0 to reflect the new APIs required by report show and list. Relates to JIRA: DISCOVERY-1272
1 parent 89f82eb commit 56521e2

6 files changed

Lines changed: 2 additions & 8 deletions

File tree

qpc/clicommand.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ def __init__( # noqa: PLR0913
2525
self.req_headers = None
2626
self.response = None
2727

28-
# If you add or change API, you must update these versions
29-
# this includes self.min_server_version
28+
# Minimum server version required by the CLI
3029
self.min_server_version = QPC_MIN_SERVER_VERSION
3130

3231
def _validate_args(self):

qpc/report/deployments.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ def __init__(self, subparsers):
7474
help=_(messages.REPORT_PATH_HELP),
7575
)
7676
self.report_id = None
77-
self.min_server_version = "0.9.2"
7877

7978
def _validate_args(self): # noqa: PLR0912
8079
CliCommand._validate_args(self)

qpc/report/details.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ def __init__(self, subparsers):
7474
help=_(messages.REPORT_PATH_HELP),
7575
)
7676
self.report_id = None
77-
self.min_server_version = "0.9.2"
7877

7978
def _validate_args(self): # noqa: PLR0912
8079
CliCommand._validate_args(self)

qpc/report/download.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ def __init__(self, subparsers):
5454
help=_(messages.DOWNLOAD_PATH_HELP),
5555
required=True,
5656
)
57-
self.min_server_version = "0.9.2"
5857
self.report_id = None
5958

6059
def _validate_args(self):

qpc/report/insights.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ def __init__(self, subparsers):
5555
metavar="PATH",
5656
help=_(messages.REPORT_PATH_HELP),
5757
)
58-
# Don't change this when you upgrade versions
59-
self.min_server_version = "0.9.0"
6058
self.report_id = None
6159

6260
def _insights_report_available(self, sources):

qpc/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454

5555
LOG_LEVEL_INFO = 0
5656

57-
QPC_MIN_SERVER_VERSION = "2.4.0"
57+
QPC_MIN_SERVER_VERSION = "2.5.0"
5858

5959
logging.captureWarnings(True)
6060
logger = logging.getLogger(__name__)

0 commit comments

Comments
 (0)