Removed the polling mechanism in favor of PhantomJS 1.6+'s WebPage#onCallback

[JamesMGreene]

• Removed the polling mechanism in favor of the PhantomJS 1.6+ callback mechanism (WebPage#onCallback).
• Added argument length checking.
• Added QUnit object detection to avoid an infinite wait if accidentally pointed at a page without QUnit.
• Standardized the coding style.
• Added/updated comments and README.
• Made some minor performance tweaks.

[Krinkle]

Note that the phantomjs addon in this repository is fairly old. Though improvements are most certainly welcome, it was no doubt in bad shape.

A lot of effort has gone into https://github.com/gruntjs/grunt-contrib-qunit, perhaps you can look there for some ideas and incorporate that in here instead. A central solution to the qunit <-> phantomjs communication (So that grunt-contrib-qunit can just use this addon and merely aggregate that instead of reinventing it all).

At this point however QUnit's own test suite is ran from jQuery's Jenkins server with the grunt solution. We don't even use this phantomjs file ourselves.

[JamesMGreene]

If that's the case, then I'd suggest that either my pull request is accepted or else the addon is deleted. Rough code and wasted effort both make me sad. 😢

[Krinkle]

Don't worry. The refactor you did here is imho definitely the way to go. Certainly better than both the old addon as well as the grunt plugin.

We can update it later if it needs more to be able to replace the code in grunt, but that's for later. As soon as I've verified this works I'll merge it as-is (or @jzaefferer ).

Thanks!

[JamesMGreene]

OK, sounds good. I'm happy to help with Grunt's plugin, too. I'm busy trying to keep up with the 24 Pull Requests season so I'm sure I can squeeze that in some night. ;)

[jzaefferer]

Thanks! Landed in 1aad036 and updated in 0552f0d to also include stacktraces.

[jzaefferer]

I've also opened this: gruntjs/grunt-lib-phantomjs#6