Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme for the UI of the extension itself #392

Open
yaycupcake opened this issue Dec 1, 2022 · 8 comments · May be fixed by #776
Open

Light theme for the UI of the extension itself #392

yaycupcake opened this issue Dec 1, 2022 · 8 comments · May be fixed by #776
Labels
enhancement Feature work
Milestone

Comments

@yaycupcake
Copy link

Is there a light theme already implemented under some menu I don't see? I am referring to the overall interface of the extension. I have trouble reading dark theme (which is why I need an extension like this in the first place, to write my own styles that are readable for my eyes) but it defeats the point without a light theme option.

I'm a developer and I'm willing to write it or help write it but I noticed you preferred to not receive spontaneous PRs which is why I am submitting an issue instead. Please let me know!

@ACTCD ACTCD added enhancement Feature work discussion Any question, feedback or general comment good first issue labels Dec 1, 2022
@ACTCD
Copy link
Collaborator

ACTCD commented Dec 1, 2022

Thanks for your feedback.

Yes, I think currently we don't have a light theme. I used to mentioned this requirement to @quoid but we didn't talk too much because we had more priority refactoring work to do.

I understand and value this need, it should be given more consideration. I'll invite @quoid for more thoughts and information on this as well.

Since we're currently doing a major environment refactoring, we need more communication about direct contributions in case you're working on an old branch.

Thanks again for your thoughtfulness and help.

@ACTCD
Copy link
Collaborator

ACTCD commented Dec 1, 2022

If you have a Matrix ID, we can invite you into our development group where we can have more direct communication. If you don't want it posted here, you can drop @quoid an email. If you don't have this account, don't worry, we can show you how to get one later if needed, it's very easy and open. In any case, you can continue to communicate by commenting here.

@quoid
Copy link
Owner

quoid commented Dec 1, 2022

Light theme would be a valuable contribution! As @ACTCD has said, feel free to send your matrix id or shoot me an email and we can collaborate through there.

@quoid quoid removed the good issue label May 1, 2023
@Foxtaur
Copy link

Foxtaur commented Aug 14, 2024

This issue doesn't seem very popular. But let me please offer my vote.

Dark mode isn't readable by all users. A light theme would raise the usability of this already great extension.

Thanks for listening.

@ACTCD
Copy link
Collaborator

ACTCD commented Aug 19, 2024

@Foxtaur No, it's valued by us, it's just that we have some current priorities that need to be realized.
And in our recent refactoring, we're already looking at improving the a11y experience in some ways.

@ACTCD ACTCD added this to the v5.x milestone Aug 19, 2024
@ACTCD
Copy link
Collaborator

ACTCD commented Oct 30, 2024

Just an update, we are trying to make a light theme.
And we want to meet basic requirements like minimum contrast.

Most rich colors seem to have better contrast in dark mode.
So we want to know what colors will help you read if you prefer a light theme.

We will release a beta version of the new light theme in the near future.
So stay tuned and let us know how your eyes feel, and thanks for waiting.

@yaycupcake
Copy link
Author

yaycupcake commented Oct 30, 2024

Hi I'm definitely still interested in helping with this.

I would honestly need to see color options visually to know what is a good reading/viewing experience and what isn't. I've found that some bolder colors can work well on light themes (a deep forest green, or a darker goldenrod or honey color), for lighter foreground colors, in the same way that a pastel or sky blue would work better than a dark navy blue on a dark theme.

You can reach me at @cupcake:chat.blahaj.zone on Matrix as well, I've recently made an account there.

@ACTCD
Copy link
Collaborator

ACTCD commented Oct 30, 2024

@yaycupcake That's great. I've invited you into our development room.

@ACTCD ACTCD removed the discussion Any question, feedback or general comment label Jan 6, 2025
quoid added a commit that referenced this issue Mar 2, 2025
Add CSS variables for light mode color palette and refactor components to
use theme variables instead of explicit color values. This groundwork prepares
the codebase for theme switching.

Resolves #392
@quoid quoid linked a pull request Mar 2, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants