Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full codebase rewrite #109

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Full codebase rewrite #109

wants to merge 34 commits into from

Conversation

qxb3
Copy link
Owner

@qxb3 qxb3 commented Feb 28, 2025

From #98:

Motivations:

  • Everything is confusing.
  • mpris crate doesn't support async and unmaintaned.
  • Everything is done thru polling because of above. Meaning that every some milliseconds or whatever u put in the fps it will fetch a new music info which is not ideal for performance and i want to update the song as soon as the music metadata changes.
  • I want async
  • I want async
  • I want async
  • Please let me have my beloved tokio!
  • Transitioning to async means that fetching and displaying the cover art will be done async and will not block rendering, same can said on input handling.
  • So i can procrastinate on other projects.
  • Also be rewriting the internals of widget placements. Things can be unpredictable.

Features i want to add (no pinky promise):

  • Have an option to just play your mp3's. This way fum will be a dedicated music player instead of relying on mpris. mpris feature will still exists and will be the default.
  • Track or Playlist viewer / selector widget. so this thing can be possible (it looks so cool)

Image

@qxb3 qxb3 added the enhancement New feature or request label Feb 28, 2025
@qxb3 qxb3 self-assigned this Feb 28, 2025
@qxb3 qxb3 linked an issue Feb 28, 2025 that may be closed by this pull request
9 tasks
@qxb3 qxb3 marked this pull request as draft February 28, 2025 21:31
@qxb3
Copy link
Owner Author

qxb3 commented Mar 15, 2025

After fighting async for a week, i finally have something

@qxb3
Copy link
Owner Author

qxb3 commented Mar 15, 2025

hell yea!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full code base rewrite & some features
1 participant