Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs 17918, 18143, 18145 - debugcall() issues #2

Open
bastistician opened this issue Jun 20, 2022 · 6 comments
Open

Bugs 17918, 18143, 18145 - debugcall() issues #2

bastistician opened this issue Jun 20, 2022 · 6 comments
Labels
discuss fix Add comment(s) on how to fix the bug Misc Issues that cannot be classified otherwise

Comments

@bastistician
Copy link

https://bugs.r-project.org/show_bug.cgi?id=17918

  • Maybe we can get func simply by evaluating call[[1L]] in parent.frame(2L)?
  • The current patch proposal also adds an environment arg to the methods::isGeneric(funsym) call, which actually seems to be one option to fix Bug 18143 (another one is to use the fdef argument of isGeneric()).
  • Bug 18145 highlights a problem with func <- getS3method(genname, class(arg)), which does not reliably find the S3 method that will eventually be called. Furthermore, class(arg) is bad as getS3method() expects a single class name.

These related issues are best worked on in one go.

@bastistician bastistician added the discuss fix Add comment(s) on how to fix the bug label Jun 20, 2022
@hturner hturner added the Misc Issues that cannot be classified otherwise label Jun 21, 2022
@gmbecker
Copy link

As I'm responsible for that I'm happy to collaborate on a fix in either direction (i.e., with me working in collab with R-core, or me mentoring/overseeing work by others in prep for submission to R-core).

I will be on hand for Sessions 1 and 3

@gmbecker
Copy link

I have started working on fixes to at least some of these issues and will continue

@gmbecker
Copy link

I have filed (one part) of the isGeneric bug we unearthed during our exploration of this here: https://bugs.r-project.org/show_bug.cgi?id=18369

@gmbecker
Copy link

I've filed the narrower, separable warning bug here: https://bugs.r-project.org/show_bug.cgi?id=18370 with a patch

@bastistician
Copy link
Author

@gmbecker: Thank you for your inputs on these issues. I'll have a look later this week.

@gmbecker
Copy link

I've submitted a patch for https://bugs.r-project.org/show_bug.cgi?id=18145 which also fixes https://bugs.r-project.org/show_bug.cgi?id=18143 in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss fix Add comment(s) on how to fix the bug Misc Issues that cannot be classified otherwise
Projects
None yet
Development

No branches or pull requests

3 participants