Skip to content

Implement helper for data frame subset assignment #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krlmlr opened this issue Sep 24, 2022 · 0 comments
Open

Implement helper for data frame subset assignment #1678

krlmlr opened this issue Sep 24, 2022 · 0 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Sep 24, 2022

I have isolated a function in tibble that implements clean subset assignment, without tibble's quirks. This function could move to vctrs, and be reimplemented here in C.

The R code for this function, and helper functions, is here:

https://github.com/tidyverse/tibble/pull/1473/files#diff-99ebfcc4d379143562ab114b81972093b641cd4ce538a91b32393ba872b3a1de

What's a good way to move forward? Should I draft a vctrs PR with tests?

I had attempted a C implementation of one of the helper functions in tidyverse/tibble#1368.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant