feat: convert services to new install script template (#1282)

Feature: Refactor Service Installation Scripts to Use Standard Template

This PR updates all services install/upgrade script to conform to the standard bash template.
Key Changes & Benefits:
    Standardization: Adopts the robust, array-based command construction (helm_command) for safer execution and argument quoting.
    Dynamic Values Loading: Switches to the standard loop logic for reliably including all .yaml files from both the base and custom override directories (/opt/genestack/base-helm-configs/redis-sentinel and /etc/genestack/helm-configs/redis-sentinel).
    Improved Reliability: Ensures consistent extraction of the service chart version using the defined SERVICE_NAME variable.
    GITHUB ACTIONS: Ensures that a github action exists for each service for pre-commit checking

This change reduces technical debt and makes the script easier to audit and maintain.

Author: rackerchris

.github/workflows/helm-loki.yaml

@@ -28,9 +28,10 @@ jobs:
         run: |
           ${{ steps.helm.outputs.helm-path }} repo add grafana https://grafana.github.io/helm-charts
           ${{ steps.helm.outputs.helm-path }} repo update
-          ${{ steps.helm.outputs.helm-path }} template --values ${{ github.workspace }}/base-helm-configs/loki/loki-helm-minio-overrides-example.yaml \
+          ${{ steps.helm.outputs.helm-path }} template -f ${{ github.workspace }}/base-helm-configs/loki/loki-helm-minio-overrides-example.yaml \
                                                        --set loki.useTestSchema=true \
                                                        --namespace grafana \
+                                                       --set loki.storage.bucketNames.chunks=chunky \
                                                         loki grafana/loki > /tmp/rendered.yaml
       - name: Return helm Build
         uses: actions/upload-artifact@v4

.github/workflows/helm-prometheus-mysql-exporter.yaml

@@ -31,7 +31,7 @@ jobs:
           ${{ steps.helm.outputs.helm-path }} template prometheus-mysql-exporter prometheus-community/prometheus-mysql-exporter \
             --create-namespace \
             --namespace=prometheus \
-            -f ${{ github.workspace }}//base-helm-configs/prometheus-mysql-exporter/values.yaml \
+            -f ${{ github.workspace }}//base-helm-configs/prometheus-mysql-exporter/prometheus-mysql-exporter-helm-overrides.yaml \
             --post-renderer ${{ github.workspace }}/base-kustomize/kustomize.sh \
             --post-renderer-args prometheus-mysql-exporter/${{ matrix.overlays }} > /tmp/rendered.yaml
       - name: Return helm Build

.github/workflows/helm-prometheus-postgres-exporter.yaml

@@ -31,7 +31,7 @@ jobs:
           ${{ steps.helm.outputs.helm-path }} template prometheus prometheus-community/prometheus-postgres-exporter \
             --create-namespace \
             --namespace=prometheus \
-            -f ${{ github.workspace }}//base-helm-configs/prometheus-postgres-exporter/values.yaml \
+            -f ${{ github.workspace }}//base-helm-configs/prometheus-postgres-exporter/prometheus-postgres-exporter-helm-overrides.yaml \
             --post-renderer ${{ github.workspace }}/base-kustomize/kustomize.sh \
             --post-renderer-args prometheus-postgres-exporter/${{ matrix.overlays }} > /tmp/rendered.yaml
       - name: Return helm Build

.github/workflows/helm-prometheus-pushgateway.yaml

@@ -31,7 +31,7 @@ jobs:
           ${{ steps.helm.outputs.helm-path }} template prometheus-pushgateway prometheus-community/prometheus-pushgateway \
             --create-namespace \
             --namespace=prometheus \
-            -f ${{ github.workspace }}//base-helm-configs/prometheus-pushgateway/values.yaml \
+            -f ${{ github.workspace }}//base-helm-configs/prometheus-pushgateway/prometheus-pushgateway-helm-overrides.yaml \
             --post-renderer ${{ github.workspace }}/base-kustomize/kustomize.sh \
             --post-renderer-args prometheus-pushgateway/${{ matrix.overlays }} > /tmp/rendered.yaml
       - name: Return helm Build

.github/workflows/helm-redis-sentinel.yaml

@@ -0,0 +1,41 @@
+name: Helm GitHub Actions for redis-sentinel
+
+on:
+  pull_request:
+    paths:
+      - base-helm-configs/redis-sentinel/**
+      - base-kustomize/redis-sentinel/**
+      - .github/workflows/helm-redis-sentinel.yaml
+jobs:
+  helm:
+    strategy:
+      matrix:
+        overlays:
+          - base
+    name: Helm
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - uses: azure/setup-helm@v3
+        with:
+          version: latest
+          token: "${{ secrets.GITHUB_TOKEN }}"
+        id: helm
+      - name: Add ot-helm (redis) to helm
+        run: |
+            ${{ steps.helm.outputs.helm-path }} repo add ot-helm https://ot-container-kit.github.io/helm-charts/
+            ${{ steps.helm.outputs.helm-path }} repo update
+      - name: Run Helm Template
+        run: |
+          ${{ steps.helm.outputs.helm-path }} template redis-sentinel ot-helm/redis-sentinel \
+            --create-namespace \
+            --namespace=redis-system \
+            -f ${{ github.workspace }}//base-helm-configs/redis-sentinel/redis-sentinel-helm-overrides.yaml \
+            --post-renderer ${{ github.workspace }}/base-kustomize/kustomize.sh \
+            --post-renderer-args redis-sentinel/${{ matrix.overlays }} > /tmp/rendered.yaml
+      - name: Return helm Build
+        uses: actions/upload-artifact@v4
+        with:
+          name: helm-redis-sentinel-artifact-${{ matrix.overlays }}
+          path: /tmp/rendered.yaml

base-helm-configs/barbican/barbican-helm-overrides.yaml

@@ -1,18 +1,18 @@
 ---
 images:
   tags:
-    barbican_api: "ghcr.io/rackerlabs/genestack-images/barbican:2024.1-latest"
-    barbican_db_sync: "ghcr.io/rackerlabs/genestack-images/barbican:2024.1-latest"
-    bootstrap: "ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest"
-    db_drop: "ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest"
-    db_init: "ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest"
-    dep_check: "ghcr.io/rackerlabs/genestack-images/kubernetes-entrypoint:latest"
-    image_repo_sync: null
-    ks_endpoints: "ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest"
-    ks_service: "ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest"
-    ks_user: "ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest"
-    rabbit_init: null
-    scripted_test: "ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest"
+    barbican_api: ghcr.io/rackerlabs/genestack-images/barbican:2024.1-latest
+    barbican_db_sync: ghcr.io/rackerlabs/genestack-images/barbican:2024.1-latest
+    bootstrap: ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest
+    db_drop: ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest
+    db_init: ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest
+    dep_check: ghcr.io/rackerlabs/genestack-images/kubernetes-entrypoint:latest
+    image_repo_sync:
+    ks_endpoints: ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest
+    ks_service: ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest
+    ks_user: ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest
+    rabbit_init:
+    scripted_test: ghcr.io/rackerlabs/genestack-images/heat:2024.1-latest
 
 # NOTE: (brew) CPU requests values based on a three node
 # hyperconverged lab (/scripts/hyperconverged-lab.sh).
@@ -22,8 +22,8 @@ pod:
     enabled: true
     api:
       requests:
-        memory: "256Mi"
-        cpu: "100m"
+        memory: 256Mi
+        cpu: 100m
       limits: {}
   lifecycle:
     upgrades:
@@ -37,7 +37,7 @@ pod:
 dependencies:
   static:
     db_sync:
-      jobs: null
+      jobs:
     api:
       jobs:
         - barbican-db-sync
@@ -47,7 +47,7 @@ dependencies:
 conf:
   barbican:
     DEFAULT:
-      host_href: "http://barbican-api.openstack.svc.cluster.local:9311"
+      host_href: http://barbican-api.openstack.svc.cluster.local:9311
     database:
       connection_debug: 0
       connection_recycle_time: 600

base-helm-configs/envoyproxy-gateway/envoy-gateway-helm-overrides.yaml renamed to base-helm-configs/envoyproxy-gateway/envoyproxy-gateway-helm-overrides.yaml

@@ -0,0 +1 @@
+---