correctly use interval-map to limit reported actions

Signed-off-by: Lîm Tsú-thuàn <[email protected]>

Author: dannypsnl

doc-trace.rkt

@@ -22,7 +22,7 @@
     (define completions (list))
     (define requires (make-interval-map))
     (define definitions (make-hash))
-    (define quickfixs (mutable-set))
+    (define quickfixs (make-interval-map))
     ;; decl -> (set pos ...)
     (define sym-decls (make-interval-map))
     ;; pos -> decl
@@ -35,7 +35,7 @@
       (set! sym-bindings (make-interval-map))
       (set! requires (make-interval-map))
       (set! definitions (make-hash))
-      (set! quickfixs (mutable-set)))
+      (set! quickfixs (make-interval-map)))
     (define/public (expand start end)
       (define inc (- end start))
       (move-interior-intervals sym-decls (- start 1) inc)
@@ -94,20 +94,21 @@
                                  #:source (path->uri src-obj)
                                  #:message "unused variable"))
 
-        (set-add! quickfixs
-                  (CodeAction
-                   #:title "Add prefix `_` to ignore"
-                   #:kind "quickfix"
-                   #:diagnostics (list diag)
-                   #:isPreferred #f
-                   #:edit (WorkspaceEdit
-                           #:changes
-                           (hasheq (string->symbol (path->uri src-obj))
-                                   (TextEdit #:range (Range #:start (abs-pos->Pos doc-text start)
-                                                            #:end   (abs-pos->Pos doc-text finish))
-                                             #:newText "_")))
-                   #:data (Range #:start (abs-pos->Pos doc-text start)
-                                 #:end   (abs-pos->Pos doc-text finish))))
+        (interval-map-set!
+         quickfixs start (add1 finish)
+         (CodeAction
+          #:title "Add prefix `_` to ignore"
+          #:kind "quickfix"
+          #:diagnostics (list diag)
+          #:isPreferred #f
+          #:edit (WorkspaceEdit
+                  #:changes
+                  (hasheq (string->symbol (path->uri src-obj))
+                          (TextEdit #:range (Range #:start (abs-pos->Pos doc-text start)
+                                                   #:end   (abs-pos->Pos doc-text finish))
+                                    #:newText "_")))
+          #:data (Range #:start (abs-pos->Pos doc-text start)
+                        #:end   (abs-pos->Pos doc-text finish))))
 
         (set-add! warn-diags diag)))
     (define/override (syncheck:add-mouse-over-status src-obj start finish text)

text-document.rkt

@@ -153,17 +153,19 @@
 (define (code-action id params)
   (match params
     [(hash-table ['textDocument (DocIdentifier #:uri uri)]
-                 ['range range]
+                 ['range (Range #:start start #:end _end)]
                  ; TODO: _ctx has three fields
                  ; 1. `diagnostics`
                  ; 2. `only: CodeActionKind[]` server should use this to filter out client-unwanted code action
                  ; 3. `triggerKind?: CodeActionTriggerKind` the reason why code action were requested
                  ['context _ctx])
      #:when (uri-is-path? uri)
-     (match-define (doc _doc-text doc-trace)
+     (match-define (doc doc-text doc-trace)
        (hash-ref open-docs (string->symbol uri)))
-     (define code-action-list (set->list (send doc-trace get-quickfixs)))
-     (success-response id code-action-list)]
+     (define act (interval-map-ref (send doc-trace get-quickfixs) (Pos->abs-pos doc-text start) #f))
+     (if act
+         (success-response id (list act))
+         (success-response id (list)))]
     [(hash-table ['textDocument (DocIdentifier #:uri uri)])
      (error-response id INVALID-PARAMS (format "textDocument/codeAction failed uri is not a path ~a" uri))]
     [_ (error-response id INVALID-PARAMS "textDocument/codeAction failed")]))