docs: clarify input element container incompatibility in React #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated-by: aiautocommit
|
@iloveitaly is attempting to deploy a commit to the Radar Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the autocomplete documentation to clarify that using an <input/> element as the container ref is incompatible with React and may lead to unexpected DOM mutations.
- Added a note explaining the incompatibility of
<input/>as the container argument in React. - Instructed users to provide a non-input container reference when integrating with React.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Wasted time debugging radar autocomplete with react :)
Why?
The docs did not make it clear that the
<input/>reference is not compatible with React.How?
doc change
Screenshots (optional)
NA
Anything Else? (optional)
I've written a ShadCN library for Radar. Can it be included in the documentation in some way?
https://github.com/iloveitaly/shadcn-radar-address-autocomplete