astyle broken formatter

[Icy-Thought]

You have to manually add the code provided below to your emacs configuration file for the apheleia astyle formatter to function as intended. Maybe we should upstream the solution that hlissner has come up with?

(setf (alist-get 'astyle apheleia-formatters)
        '("astyle" (mapconcat 'identity (apheleia-formatters-locate-file "--options=" ".astylerc"))))

Source: doomemacs/doomemacs#7718

[raxod502]

Wait, I'm a bit confused by the discussion there. What's the proposed change? Seems like the mapconcat thing and the modified command-line option is contributed by the original reporter, who is confused that those modifications are not taking effect? What is the bug in Apheleia? I.e. what happens with the default configuration that's wrong?

[Icy-Thought]

IIRC (not using astyle), but executing apehelia-format-buffer did not change the formatting of the viewed buffer. (command below)

apheleia/apheleia-formatters.el

Lines 24 to 25 in e112fe1

	'((astyle . ("astyle" (apheleia-formatters-locate-file
	"--options" ".astylerc")))

But with the apheleia-formatters entry for astyle (found in doomemacs), it worked fine. I wonder what caused the issue tbh.

[raxod502]

So the difference is... what? Using --options=.astylerc instead of --options .astylerc?

[Icy-Thought]

From https://astyle.sourceforge.net/astyle.html#_Option_Files, that appears to be the case.

[raxod502]

OK, I would accept that as a contribution. (Ideally it would be tested to verify that that's actually the issue.)

[Icy-Thought]

I didn't submit a PR because I am not the owner of that code. But I can always create a PR if you'd like.

[raxod502]

Up to you.