@@ -26,9 +26,9 @@ This plan addresses:
2626
2727** Purpose** : Prepare pnpm tooling and verify prerequisites
2828
29- - [ ] T001 Verify Plan 1 (Go modules migration) is merged to main
30- - [ ] T002 Verify pnpm is installed locally via ` pnpm --version `
31- - [ ] T003 Identify current bicep-types submodule commit SHA for pnpm git references via ` git submodule status ` in radius/
29+ - [x ] T001 Verify Plan 1 (Go modules migration) is merged to main
30+ - [x ] T002 Verify pnpm is installed locally via ` pnpm --version `
31+ - [x ] T003 Identify current bicep-types submodule commit SHA for pnpm git references via ` git submodule status ` in radius/
3232
3333---
3434
@@ -38,9 +38,9 @@ This plan addresses:
3838
3939** ⚠️ CRITICAL** : Complete before any user story implementation
4040
41- - [ ] T004 Create feature branch ` 001-remove-bicep-types-submodule-pnpm ` from main
42- - [ ] T005 Pull latest main to ensure Plan 1 changes are included
43- - [ ] T006 Verify current build works via ` make build ` in radius/
41+ - [x ] T004 Create feature branch ` 001-remove-bicep-types-submodule-pnpm ` from main
42+ - [x ] T005 Pull latest main to ensure Plan 1 changes are included
43+ - [x ] T006 Verify current build works via ` make build ` in radius/
4444
4545** Checkpoint** : Foundation ready - pnpm migration can proceed
4646
@@ -56,34 +56,34 @@ This plan addresses:
5656
5757#### pnpm Migration - typespec/
5858
59- - [ ] T007 [ US1] Delete radius/typespec/package-lock.json
60- - [ ] T008 [ US1] Generate pnpm lockfile via ` pnpm install ` in radius/typespec/
61- - [ ] T009 [ US1] Verify typespec builds via ` pnpm run build ` in radius/typespec/
59+ - [x ] T007 [ US1] Delete radius/typespec/package-lock.json
60+ - [x ] T008 [ US1] Generate pnpm lockfile via ` pnpm install ` in radius/typespec/
61+ - [x ] T009 [ US1] Verify typespec builds via ` pnpm run build ` in radius/typespec/
6262
6363#### pnpm Migration - hack/bicep-types-radius/src/generator/
6464
65- - [ ] T010 [ US1] Update radius/hack/bicep-types-radius/src/generator/package.json: change bicep-types from ` file: ` to ` github:Azure/bicep-types#<sha>&path:/src/bicep-types `
66- - [ ] T011 [ US1] Delete radius/hack/bicep-types-radius/src/generator/package-lock.json
67- - [ ] T012 [ US1] Generate pnpm lockfile via ` pnpm install ` in radius/hack/bicep-types-radius/src/generator/
68- - [ ] T013 [ US1] Verify generator builds via ` pnpm run build ` in radius/hack/bicep-types-radius/src/generator/
65+ - [x ] T010 [ US1] Update radius/hack/bicep-types-radius/src/generator/package.json: change bicep-types from ` file: ` to npm registry version ` ^0.6.49-g556bf5edad `
66+ - [x ] T011 [ US1] Delete radius/hack/bicep-types-radius/src/generator/package-lock.json
67+ - [x ] T012 [ US1] Generate pnpm lockfile via ` pnpm install ` in radius/hack/bicep-types-radius/src/generator/
68+ - [x ] T013 [ US1] Verify generator builds via ` pnpm run build ` in radius/hack/bicep-types-radius/src/generator/
6969
7070#### pnpm Migration - hack/bicep-types-radius/src/autorest.bicep/
7171
72- - [ ] T014 [ US1] Update radius/hack/bicep-types-radius/src/autorest.bicep/package.json: change bicep-types from ` file: ` to ` github:Azure/bicep-types#<sha>&path:/src/bicep-types `
73- - [ ] T015 [ US1] Delete radius/hack/bicep-types-radius/src/autorest.bicep/package-lock.json
74- - [ ] T016 [ US1] Generate pnpm lockfile via ` pnpm install ` in radius/hack/bicep-types-radius/src/autorest.bicep/
75- - [ ] T017 [ US1] Verify autorest.bicep builds via ` pnpm run build ` in radius/hack/bicep-types-radius/src/autorest.bicep/
72+ - [x ] T014 [ US1] Update radius/hack/bicep-types-radius/src/autorest.bicep/package.json: change bicep-types from ` file: ` to npm registry version ` ^0.6.49-g556bf5edad `
73+ - [x ] T015 [ US1] Delete radius/hack/bicep-types-radius/src/autorest.bicep/package-lock.json
74+ - [x ] T016 [ US1] Generate pnpm lockfile via ` pnpm install ` in radius/hack/bicep-types-radius/src/autorest.bicep/
75+ - [x ] T017 [ US1] Verify autorest.bicep builds via ` pnpm run build ` in radius/hack/bicep-types-radius/src/autorest.bicep/
7676
7777#### Submodule Removal
7878
79- - [ ] T018 [ US1] Remove submodule from git index via ` git rm bicep-types ` in radius/
80- - [ ] T019 [ US1] Delete radius/.gitmodules file
81- - [ ] T020 [ US1] Clean up .git/modules/bicep-types directory via ` rm -rf .git/modules/bicep-types `
79+ - [x ] T018 [ US1] Remove submodule from git index via ` git rm bicep-types ` in radius/
80+ - [x ] T019 [ US1] Delete radius/.gitmodules file
81+ - [x ] T020 [ US1] Clean up .git/modules/bicep-types directory via ` rm -rf .git/modules/bicep-types `
8282
8383#### Verify Build Works
8484
85- - [ ] T021 [ US1] Verify full build via ` make build ` in radius/
86- - [ ] T022 [ US1] Verify tests via ` make test ` in radius/
85+ - [x ] T021 [ US1] Verify full build via ` make build ` in radius/
86+ - [x ] T022 [ US1] Verify tests via ` make test ` in radius/
8787
8888** Checkpoint** : Repository builds and tests pass without submodule
8989
@@ -99,33 +99,33 @@ This plan addresses:
9999
100100#### Makefile Updates
101101
102- - [ ] T023 [ US2] Update radius/build/generate.mk: replace ` npm ` commands with ` pnpm `
103- - [ ] T024 [ US2] Update radius/build/generate.mk: remove ` git submodule update --init --recursive ` commands
104- - [ ] T025 [ US2] Verify ` make generate-bicep-types ` works in radius/
102+ - [x ] T023 [ US2] Update radius/build/generate.mk: replace ` npm ` commands with ` pnpm `
103+ - [x ] T024 [ US2] Update radius/build/generate.mk: remove ` git submodule update --init --recursive ` commands
104+ - [x ] T025 [ US2] Verify ` make generate-bicep-types ` works in radius/
105105
106106#### Workflow Updates - build.yaml (4 occurrences)
107107
108- - [ ] T026 [ US2] Update radius/.github/workflows/build.yaml line ~ 110: remove ` submodules: recursive ` from checkout step
109- - [ ] T027 [ US2] Update radius/.github/workflows/build.yaml line ~ 212: remove ` submodules: recursive ` from checkout step
110- - [ ] T028 [ US2] Update radius/.github/workflows/build.yaml line ~ 369: remove ` submodules: recursive ` from checkout step
111- - [ ] T029 [ US2] Update radius/.github/workflows/build.yaml line ~ 436: remove ` submodules: recursive ` from checkout step
112- - [ ] T030 [ US2] Add pnpm setup step to radius/.github/workflows/build.yaml (pnpm/action-setup@v4)
108+ - [x ] T026 [ US2] Update radius/.github/workflows/build.yaml line ~ 110: remove ` submodules: recursive ` from checkout step
109+ - [x ] T027 [ US2] Update radius/.github/workflows/build.yaml line ~ 212: remove ` submodules: recursive ` from checkout step
110+ - [x ] T028 [ US2] Update radius/.github/workflows/build.yaml line ~ 369: remove ` submodules: recursive ` from checkout step
111+ - [x ] T029 [ US2] Update radius/.github/workflows/build.yaml line ~ 436: remove ` submodules: recursive ` from checkout step
112+ - [x ] T030 [ US2] Add pnpm setup step to radius/.github/workflows/build.yaml (pnpm/action-setup@v4)
113113
114114#### Workflow Updates - Other Files
115115
116- - [ ] T031 [ P] [ US2] Update radius/.github/workflows/codeql.yml line ~ 95: remove ` submodules: recursive ` , add pnpm setup
117- - [ ] T032 [ P] [ US2] Update radius/.github/workflows/lint.yaml line ~ 58: remove ` submodules: recursive ` , add pnpm setup
118- - [ ] T033 [ P] [ US2] Update radius/.github/workflows/validate-bicep.yaml line ~ 64: remove ` submodules: true ` , add pnpm setup
119- - [ ] T034 [ P] [ US2] Update radius/.github/workflows/publish-docs.yaml line ~ 52: remove ` submodules: recursive ` , add pnpm setup
120- - [ ] T035 [ P] [ US2] Update radius/.github/workflows/long-running-azure.yaml line ~ 136: remove ` submodules: recursive ` , add pnpm setup
116+ - [x ] T031 [ P] [ US2] Update radius/.github/workflows/codeql.yml line ~ 95: remove ` submodules: recursive ` , add pnpm setup
117+ - [x ] T032 [ P] [ US2] Update radius/.github/workflows/lint.yaml line ~ 58: remove ` submodules: recursive ` , add pnpm setup
118+ - [x ] T033 [ P] [ US2] Update radius/.github/workflows/validate-bicep.yaml line ~ 64: remove ` submodules: true ` , add pnpm setup
119+ - [x ] T034 [ P] [ US2] Update radius/.github/workflows/publish-docs.yaml line ~ 52: remove ` submodules: recursive ` , add pnpm setup
120+ - [x ] T035 [ P] [ US2] Update radius/.github/workflows/long-running-azure.yaml line ~ 136: remove ` submodules: recursive ` , add pnpm setup
121121
122122#### Workflow Updates - Functional Tests (4 occurrences in cloud.yaml)
123123
124- - [ ] T036 [ US2] Update radius/.github/workflows/functional-test-noncloud.yaml line ~ 208: remove ` submodules: recursive ` , add pnpm setup
125- - [ ] T037 [ US2] Update radius/.github/workflows/functional-test-cloud.yaml line ~ 172: remove ` submodules: recursive ` , add pnpm setup
126- - [ ] T038 [ US2] Update radius/.github/workflows/functional-test-cloud.yaml line ~ 328: remove ` submodules: recursive ` , add pnpm setup
127- - [ ] T039 [ US2] Update radius/.github/workflows/functional-test-cloud.yaml line ~ 336: remove ` submodules: recursive ` , add pnpm setup
128- - [ ] T040 [ US2] Update radius/.github/workflows/functional-test-cloud.yaml line ~ 626: remove ` submodules: recursive ` , add pnpm setup
124+ - [x ] T036 [ US2] Update radius/.github/workflows/functional-test-noncloud.yaml line ~ 208: remove ` submodules: recursive ` , add pnpm setup
125+ - [x ] T037 [ US2] Update radius/.github/workflows/functional-test-cloud.yaml line ~ 172: remove ` submodules: recursive ` , add pnpm setup
126+ - [x ] T038 [ US2] Update radius/.github/workflows/functional-test-cloud.yaml line ~ 328: remove ` submodules: recursive ` , add pnpm setup
127+ - [x ] T039 [ US2] Update radius/.github/workflows/functional-test-cloud.yaml line ~ 336: remove ` submodules: recursive ` , add pnpm setup
128+ - [x ] T040 [ US2] Update radius/.github/workflows/functional-test-cloud.yaml line ~ 626: remove ` submodules: recursive ` , add pnpm setup
129129
130130** Checkpoint** : All 15 submodule references removed from 8 workflow files
131131
@@ -139,10 +139,10 @@ This plan addresses:
139139
140140### Implementation for User Story 3
141141
142- - [ ] T041 [ US3] Update radius/.github/dependabot.yml: remove ` gitsubmodule ` package-ecosystem section
143- - [ ] T042 [ P] [ US3] Update radius/.github/dependabot.yml: add pnpm config for ` /hack/bicep-types-radius/src/generator `
144- - [ ] T043 [ P] [ US3] Update radius/.github/dependabot.yml: add pnpm config for ` /hack/bicep-types-radius/src/autorest.bicep `
145- - [ ] T044 [ US3] Verify Dependabot config syntax via ` actionlint ` or manual review
142+ - [x ] T041 [ US3] Update radius/.github/dependabot.yml: remove ` gitsubmodule ` package-ecosystem section
143+ - [x ] T042 [ P] [ US3] Update radius/.github/dependabot.yml: add pnpm config for ` /hack/bicep-types-radius/src/generator `
144+ - [x ] T043 [ P] [ US3] Update radius/.github/dependabot.yml: add pnpm config for ` /hack/bicep-types-radius/src/autorest.bicep `
145+ - [x ] T044 [ US3] Verify Dependabot config syntax via ` actionlint ` or manual review
146146
147147** Checkpoint** : Dependabot configured for all pnpm directories
148148
@@ -174,17 +174,17 @@ This plan addresses:
174174
175175#### Dev Container
176176
177- - [ ] T048 [ US5] Update radius/.devcontainer/devcontainer.json: add corepack pnpm activation to postCreateCommand
177+ - [x ] T048 [ US5] Update radius/.devcontainer/devcontainer.json: add corepack pnpm activation to postCreateCommand
178178
179179#### Contributing Documentation
180180
181- - [ ] T049 [ P] [ US5] Update radius/CONTRIBUTING.md: replace npm with pnpm, remove all submodule references
182- - [ ] T050 [ P] [ US5] Create radius/docs/contributing/migration-guide.md with cleanup commands for existing clones
181+ - [x ] T049 [ P] [ US5] Update radius/CONTRIBUTING.md: replace npm with pnpm, remove all submodule references
182+ - [x ] T050 [ P] [ US5] Create radius/docs/contributing/migration-guide.md with cleanup commands for existing clones
183183
184184#### README Updates
185185
186- - [ ] T051 [ P] [ US5] Review and update radius/README.md if it mentions submodules
187- - [ ] T052 [ P] [ US5] Review and update radius/hack/bicep-types-radius/README.md if it exists
186+ - [x ] T051 [ P] [ US5] Review and update radius/README.md if it mentions submodules
187+ - [x ] T052 [ P] [ US5] Review and update radius/hack/bicep-types-radius/README.md if it exists
188188
189189** Checkpoint** : All documentation updated
190190
@@ -197,7 +197,7 @@ This plan addresses:
197197- [ ] T053 Run full ` make build ` in radius/
198198- [ ] T054 Run full ` make test ` in radius/
199199- [ ] T055 [ P] Run ` make generate-bicep-types ` to verify codegen workflow
200- - [ ] T056 [ P] Verify pnpm lockfiles are consistent via ` pnpm install --frozen-lockfile ` in each directory
200+ - [x ] T056 [ P] Verify pnpm lockfiles are consistent via ` pnpm install --frozen-lockfile ` in each directory
201201- [ ] T057 Fresh clone test: clone to new directory without ` --recurse-submodules ` , verify build
202202- [ ] T058 Create PR from ` 001-remove-bicep-types-submodule-pnpm ` to main
203203- [ ] T059 Verify all CI workflows pass on PR
0 commit comments