Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bit ambigous what to enter for github/validation #16

Open
PragTob opened this issue Apr 3, 2014 · 4 comments
Open

A bit ambigous what to enter for github/validation #16

PragTob opened this issue Apr 3, 2014 · 4 comments

Comments

@PragTob
Copy link
Contributor

PragTob commented Apr 3, 2014

For the new campaign I donated and in the github field entered the URL to my github page (as I was unsure whether it was github username or github url). Silly I know.

At that point the UI could state github user name (or did I just not see that)? And a validation would be nice, e.g. checking that what's entered is a valid user name not a url or specifically not a URL.

If anyone's got time I'd be happy about a fixup in the database, that's not necessary though ;)

Cheers,
Tobi

@pxlpnk
Copy link
Member

pxlpnk commented Apr 3, 2014

I fixed it in the DB for you.
validation seems like a good idea. will see if I have time for it.

@svenfuchs
Copy link
Member

I think it's a good idea to rename the label.

We also have a few bits for attribute normalization: https://github.com/rails-girls-summer-of-code/rgsoc-campaign/blob/master/app/models/donation.rb#L38-L44 Maybe we could add something similar to github_handle=. Like github_handle.to_s.split('/').last

@PragTob
Copy link
Contributor Author

PragTob commented Apr 4, 2014

Thanks or the fix and good suggestion from @svenfuchs :-)

@alicetragedy
Copy link
Member

Fixed by @lislis in rails-girls-summer-of-code/summer-of-code@cab525a so I think we can close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants