Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Ensure correct student names are in the application confirmation emails #955

Open
hola-soy-milk opened this issue Feb 28, 2018 · 9 comments

Comments

@hola-soy-milk
Copy link
Member

As quickly gone over in PR #951, we've had to temporarily disable application confirmation emails as we had an incident where students were sent the opposite applications with the opposite names.

We need to have a way to ensure that the correct student_index is used for student0 and student1.

@cesswairimu
Copy link

cesswairimu commented Mar 5, 2018

Hi @ramonh I would love to work on this issue

@hola-soy-milk
Copy link
Member Author

Hey @cesswairimu, sure thing, thank you so much for offering to help!

Please make sure to let me know if I can help you in any way.

@cesswairimu
Copy link

@ramonh after rebasing I am getting this error. Tried to find some work around but nothing seems to work.
screenshot from 2018-03-13 11-32-39

@hola-soy-milk
Copy link
Member Author

hola-soy-milk commented Mar 14, 2018

Hey @cesswairimu Thanks for bringing this up!

I tried checking out your branch and oddly enough, it seems to be working on my end. However, I'm on macOS so I suspect it could be a gem installation issue.

Did I understand correctly that it worked before?

Maybe one thing you could try is reinstalling the gems in your bundle. You can do that by running the following:

$ bundle install --force

Hope this helps!

@cesswairimu
Copy link

cesswairimu commented Mar 14, 2018

yes, It worked before. I forked the repo a while back and after pulling the lastest changes, I am getting the error. Could be something to do with the upgrade to ruby-2.5.0 I am guessing. I just tried to fork the clone the repo directly and i am getting the same error.

@hola-soy-milk
Copy link
Member Author

Very odd, and I take it re-installing the gems didn't work?

@cesswairimu
Copy link

Yep reinstalled successfully but the error persists

@hola-soy-milk
Copy link
Member Author

Aw!

Let's try a theory. Could you try opening the .ruby-version and changing it back to, what I believe was 2.3.1?

Then you can cd out and back in to try?

@cesswairimu
Copy link

👍 That works Thanks a lot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants