-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paginate workers page #28
Comments
Hi @rosa I would love to give it a try! After a first look I understand that the idea is to replicate the current behaviour of the JobsController, right? Thanks! |
@pmareke @nachiket87 Are you still working on this? I feel like there will be cross over with https://github.com/basecamp/mission_control-jobs/issues/29 so maybe you should take that one too? |
Hello, yes I would love to work on that. I believe merging this and then doing #29 would be better as it would keep the diffs smaller. |
@jaredholdcroft I asked the maintainers, as you did, and now I'm waiting for their response. |
@pmareke of course! Go for it, sorry for the delay. |
@rosa Here's the Pr https://github.com/basecamp/mission_control-jobs/pull/55 |
Hey @nachiket87, yes, please 🙏 Sorry for the confusion here, y'all. I was out last week starting on 31st January and didn't have time to catch up with all the issues and comments yesterday. |
/workers
is not currently paginated; only the pages that list jobs are. Normally there would be many less workers than jobs for most pages (eg. finished or scheduled jobs might have millions of jobs), but still, in a medium or big-ish app, there'll be surely hundreds of workers, so this page might be a bit too slow. It'd be good to have aPage
implementation we can use for workers (the existing one is tailored forJobsRelation
) and use it to paginate this.The text was updated successfully, but these errors were encountered: