Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate workers page #28

Closed
rosa opened this issue Jan 29, 2024 · 8 comments
Closed

Paginate workers page #28

rosa opened this issue Jan 29, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@rosa
Copy link
Member

rosa commented Jan 29, 2024

/workers is not currently paginated; only the pages that list jobs are. Normally there would be many less workers than jobs for most pages (eg. finished or scheduled jobs might have millions of jobs), but still, in a medium or big-ish app, there'll be surely hundreds of workers, so this page might be a bit too slow. It'd be good to have a Page implementation we can use for workers (the existing one is tailored for JobsRelation) and use it to paginate this.

@pmareke
Copy link
Contributor

pmareke commented Jan 31, 2024

Hi @rosa I would love to give it a try!

After a first look I understand that the idea is to replicate the current behaviour of the JobsController, right?

Thanks!

@jaredholdcroft
Copy link

@pmareke @nachiket87 Are you still working on this? I feel like there will be cross over with https://github.com/basecamp/mission_control-jobs/issues/29 so maybe you should take that one too?

@nachiket87
Copy link

@nachiket87 Are you still working on this? I feel like there will be cross over with https://github.com/basecamp/mission_control-jobs/issues/29 so maybe you should take that one too?

Hello, yes I would love to work on that. I believe merging this and then doing #29 would be better as it would keep the diffs smaller.

@pmareke
Copy link
Contributor

pmareke commented Feb 5, 2024

@jaredholdcroft I asked the maintainers, as you did, and now I'm waiting for their response.

@rosa
Copy link
Member Author

rosa commented Feb 6, 2024

@pmareke of course! Go for it, sorry for the delay.

@nachiket87
Copy link

nachiket87 commented Feb 6, 2024

@pmareke of course! Go for it, sorry for the delay.

@rosa
Should I close my PR since you've assigned someone to this ticket?

Here's the Pr https://github.com/basecamp/mission_control-jobs/pull/55

@pmareke
Copy link
Contributor

pmareke commented Feb 6, 2024

Thanks @rosa ❤️ .

The PR is ready #62.

@rosa
Copy link
Member Author

rosa commented Feb 6, 2024

Hey @nachiket87, yes, please 🙏 Sorry for the confusion here, y'all. I was out last week starting on 31st January and didn't have time to catch up with all the issues and comments yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants