Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the installer to account for an existing multi-existing db configuration #204

Closed
dhh opened this issue Sep 3, 2024 · 2 comments
Closed

Comments

@dhh
Copy link
Member

dhh commented Sep 3, 2024

With 1.0.3, we're modifying the config/database.yml file automatically. That works well for new out-of-the-box Rails apps. But if you've already modified that file with a multi-DB setup, or otherwise, we'll be overwriting that. This needs to be fixed before Rails 8, as both Solid Cache and Solid Queue will need to be configured out of the box.

@dhh
Copy link
Member Author

dhh commented Sep 3, 2024

If you wanted to take a stab at this @fractaledmind, here's the issue to track it.

@dhh
Copy link
Member Author

dhh commented Sep 4, 2024

Solved via 0a36dec and rails/rails@cae25f3

@dhh dhh closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant