Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New queue_schema.rb file hardcodes Rails version #323

Closed
fractaledmind opened this issue Sep 5, 2024 · 6 comments
Closed

New queue_schema.rb file hardcodes Rails version #323

fractaledmind opened this issue Sep 5, 2024 · 6 comments

Comments

@fractaledmind
Copy link

After #321, Solid Queue can't be added to any new Rails 7.2 applications. I just reported this problem with Solid Cache in rails/solid_cache#211, and this will have the exact same problem:

bin/rails aborted!
ArgumentError: Unknown migration version "8.0"; expected one of "4.2", "5.0", "5.1", "5.2", "6.0", "6.1", "7.0", "7.1", "7.2" (ArgumentError)

          raise ArgumentError, "Unknown migration version #{version.inspect}; expected one of #{versions.sort.join(', ')}"
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/fractaled/Code/Playgrounds/euruko-2024/db/cache_schema.rb:3:in `<main>'

I stumbled into this preparing my workshop for EuRuKo next week, where we are spinning up new Rails 7.2.1 apps and installing the Solid gems.

@rosa
Copy link
Member

rosa commented Sep 5, 2024

Oops, so sorry! We're running it with Rails 8, and I didn't think of that 🤦‍♀️ .

@rosa
Copy link
Member

rosa commented Sep 5, 2024

The new schema is completely compatible with Rails 7.1, which is the minimum version required to use Solid Queue, so I'll just revert to that.

@fractaledmind
Copy link
Author

Perfect. Thanks. And no worries, this is exactly the kind of tiny little bug that inevitably sneaks thru. One of the wonderful things about open source is that the collective community will do a much better job of finding all of these cases than any one individual. Excited to see things coming together for Rails 8 tho!

rosa added a commit that referenced this issue Sep 5, 2024
This is the minimum version we support, and otherwise apps using
Rails < 8 won't be able to install Solid Queue properly. Thanks a lot to
@fractaledmind for catching this in #323.
@rosa
Copy link
Member

rosa commented Sep 5, 2024

@fractaledmind would you mind double-checking that the last main works fine for you? 😅 I'll ship v.0.8.1 with if so.

@fractaledmind
Copy link
Author

Yes. bin/rails solid_queue:install followed by bin/rails db:prepare DATABASE=queue worked

@rosa
Copy link
Member

rosa commented Sep 5, 2024

Awesome! Thank you so much 🙏

@rosa rosa closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants