Unnecessary warning on Solid Queue startup

[easydatawarehousing]

On startup of Solid Queue all claimed_executions are set to failed status and a warning of this fact is added to the log. This is perfect! But when there are no claimed_executions a warning is still logged, like this:

WARN -- : SolidQueue-1.2.1 Fail claimed jobs (36.4ms) job_ids: [], process_ids: []

requiring attention further down the line.

I'm not familiar with solid_queue source code but wondering if solid_queue/app/models/solid_queue/process/executor.rb should test if any claimed_executions are present.

def fail_all_claimed_executions_with(error)
  if claims_executions? && claimed_executions.present?
    claimed_executions.fail_all_with(error)
  end
end

[rosa]

Yes, it probably makes sense. I added it all the time in the beginning for debugging purposes, but I agree it's a bit too much. At the minimum we shouldn't log it.

[easydatawarehousing]

Agree. Or, if you want to complicate things, change log level of this message to debug if no claimed_executions are present.

[yokonao]

I also encountered the same problem and was wondering about it. I also created a PR to try it out.
#643