Skip to content

Commit 83b1d5f

Browse files
committed
[go_router_builder] Fixes an deprecated warning for using withNullability
1 parent b93cc40 commit 83b1d5f

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

packages/go_router_builder/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.8.3
2+
3+
- Fixes an deprecated warning for using withNullability
4+
-
15
## 2.8.2
26

37
- Fixes an issue when enum params are not required

packages/go_router_builder/lib/src/go_router_generator.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ ${getters.map((String e) => "$e,").join('\n')}
7979
ConstantReader annotation,
8080
) {
8181
final String typedAnnotation =
82-
annotation.objectValue.type!.getDisplayString(withNullability: false);
82+
annotation.objectValue.type!.getDisplayString();
8383
final String type =
8484
typedAnnotation.substring(0, typedAnnotation.indexOf('<'));
8585
final String routeData = _annotations[type]!;

packages/go_router_builder/lib/src/route_config.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,7 @@ class StatefulShellBranchConfig extends RouteBaseConfig {
172172

173173
@override
174174
String get factorConstructorParameters => '';
175+
175176
@override
176177
String get routeConstructorParameters =>
177178
'${navigatorKey == null ? '' : 'navigatorKey: $navigatorKey,'}'
@@ -609,8 +610,7 @@ abstract class RouteBaseConfig {
609610
return false;
610611
}
611612
final DartType typeArgument = typeArguments.single;
612-
if (typeArgument.getDisplayString(withNullability: false) !=
613-
'NavigatorState') {
613+
if (typeArgument.getDisplayString() != 'NavigatorState') {
614614
return false;
615615
}
616616
}

packages/go_router_builder/lib/src/type_helpers.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ String decodeParameter(ParameterElement element, Set<String> pathParameters) {
6868

6969
throw InvalidGenerationSourceError(
7070
'The parameter type '
71-
'`${paramType.getDisplayString(withNullability: false)}` is not supported.',
71+
'`${paramType.getDisplayString()}` is not supported.',
7272
element: element,
7373
);
7474
}
@@ -111,7 +111,7 @@ String enumMapName(InterfaceType type) => '_\$${type.element.name}EnumMap';
111111
String _stateValueAccess(ParameterElement element, Set<String> pathParameters) {
112112
if (element.isExtraField) {
113113
// ignore: avoid_redundant_argument_values
114-
return 'extra as ${element.type.getDisplayString(withNullability: true)}';
114+
return 'extra as ${element.type.getDisplayString()}';
115115
}
116116

117117
late String access;

packages/go_router_builder/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: go_router_builder
22
description: >-
33
A builder that supports generated strongly-typed route helpers for
44
package:go_router
5-
version: 2.8.2
5+
version: 2.8.3
66
repository: https://github.com/flutter/packages/tree/main/packages/go_router_builder
77
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router_builder%22
88

0 commit comments

Comments
 (0)