MRWK bounty: 40 MRWK - review open MergeWork PRs with evidence, round 21

[ramimbo]

MergeWork status: live bounty

Reserved on MergeWork: https://mrwk.online/bounties/120

Claims are open only while the public bounty row remains open and effective award capacity remains. Use the public bounty page or API as the authoritative current status.

Status: pending create_bounty proposal. This issue is not claimable yet.

Wait until proposal execution creates the public bounty row and finalizes this GitHub issue with mrwk:bounty and the Reserved on MergeWork claims-open comment before treating this as live bounty work.

MRWK Bounty

Reward: 40 MRWK per accepted award
Max awards: 30

Work Needed

Review current open MergeWork pull requests with useful, evidence-backed maintainer decision support. Reviews may identify concrete defects, confirm a clean current-head change, verify tests or behavior, or explain why a PR is stale, duplicate, unsafe, out of scope, or needs contributor action.

Acceptance Criteria

• Link the reviewed pull request and exact review, PR comment, or issue comment being claimed.
• Inspect the current head state, relevant bounty reference, changed files, and visible checks before posting a verdict.
• Provide a useful decision signal for maintainers: accept/merge readiness, actionable defect, duplicate/stale finding, needs-info reason, or rejection rationale.
• Self-reviews, vague summaries, copied bot output, and reviews of superseded commits do not qualify.

How To Submit

After this issue is live, submit a focused review, PR comment, or issue comment that links this issue with Bounty #1009 or Refs #1009.

Evidence or Tests Required

• Reviewed PR number and head commit when available.
• Files or behavior inspected.
• Verdict and concise rationale.
• Validation performed, such as test output, diff inspection, linked failing checks, reproduction steps, or reason no local test was needed.
• Keep private security details, secrets, wallet recovery data, and admin tokens out of public artifacts.

Out of Scope

• Duplicate reviews that add no new evidence.
• Self-review of a contributor's own PR.
• Reviews of already-merged, closed, exhausted, or superseded work unless the review is explicitly useful for cleanup.
• Generic approval, style-only commentary, or volume-only review spam.
• Price, liquidity, bridge, exchange, cash-out, or unrelated token claims.

Duplicate and Stale Work Rules

• Duplicate work is judged by the first useful, reviewable submission that matches the bounty criteria.
• Stale claims may be ignored when they do not include reviewable evidence or no longer match current repository behavior.

[ramimbo]

Status: pending create_bounty proposal. This issue is not claimable yet.

Proposal: https://api.mrwk.online/api/v1/treasury/proposals/211
Earliest execution: 2026-06-07T12:43:39.278963Z

Wait until proposal execution creates the public bounty row and finalizes this GitHub issue with mrwk:bounty and the claims-open comment before treating this as live bounty work.

[ramimbo]

Reserved on MergeWork: https://mrwk.online/bounties/120

Claims are now open for accepted work that matches this bounty's criteria.

[modelsbridgeaicom-ship-it]

/claim

Submitted a current-head review for a third-party PR under this bounty:

• PR: Show active attempt status on bounty pages #1089
• Review: Show active attempt status on bounty pages #1089 (review)
• Reviewed head: 18d3b861f33a319e7ee8c2802652ffc25a835a27

Review verdict:

• Approved as merge-ready for the checked public bounty-page surface.
• Inspected app/templates/bounties.html, app/templates/bounty_detail.html, and tests/test_bounty_pages.py.
• Confirmed the PR only renders existing active-attempt summary fields on public bounty list/detail pages and adds page coverage for active count, warning text, and the attempts endpoint link.
• Confirmed CodeRabbit and CI are green. CodeRabbit's zero/singular boundary-case note is useful follow-up coverage, but I did not treat it as a merge blocker for this focused display change.

Validation run on exact PR head:

• python -m pytest tests\test_bounty_pages.py -q -> 23 passed, 1 existing Starlette/httpx warning.
• ruff check tests\test_bounty_pages.py -> All checks passed.
• ruff format --check tests\test_bounty_pages.py -> 1 file already formatted.
• git diff --check origin/main...HEAD -> clean.
• git merge-tree --write-tree origin/main HEAD -> clean.

Eligibility:

• PR Show active attempt status on bounty pages #1089 is open, non-draft, authored by another account, and this review was made against the current head.
• I did not find any earlier MRWK bounty: 40 MRWK - review open MergeWork PRs with evidence, round 21 #1009 claim for PR Show active attempt status on bounty pages #1089 before this submission.

Payout boundary: this is a submitted #1009 review-bounty claim only. It is not earned, accepted, pending, or withdrawable unless maintainers accept it and record proof-backed payment.

[modelsbridgeaicom-ship-it]

/claim

Submitted a current-head review for a third-party PR under this bounty:

• PR: Surface static did-you-mean suggestions for unknown MCP tool names #1081
• Review: Surface static did-you-mean suggestions for unknown MCP tool names #1081 (review)
• Reviewed head: bfd17ea6f2135e879c32e5d6fb4562e29967204f

Review verdict:

• Approved as merge-ready for the checked MCP unknown-tool error surface.
• Inspected app/mcp.py, tests/test_api_mcp.py, and docs/agent-guide.md.
• Confirmed did_you_mean is computed from the static registered MCP tool-name list, not arbitrary caller input.
• Confirmed unknown tool names keep error.data.tool as null, so the rejected name is not reflected in the response body.
• Confirmed the helper uses a stable sorted tuple for deterministic close-match tie selection and the docs describe the additive field without changing legacy JSON-RPC error semantics.

Validation run on exact PR head:

• python -m pytest tests\test_api_mcp.py -k "did_you_mean or unknown_tool or field_error" -q -> 14 passed, 128 deselected, 1 existing Starlette/httpx warning.
• python -m pytest tests\test_api_mcp.py -q -> 142 passed, 1 existing Starlette/httpx warning.
• ruff check app\mcp.py tests\test_api_mcp.py docs\agent-guide.md -> All checks passed.
• ruff format --check app\mcp.py tests\test_api_mcp.py -> 2 files already formatted.
• python -m mypy app\mcp.py -> Success.
• python scripts\docs_smoke.py -> docs smoke ok.
• git diff --check origin/main...HEAD and git diff --check -> clean.
• git merge-tree --write-tree origin/main HEAD -> clean.

Eligibility:

• PR Surface static did-you-mean suggestions for unknown MCP tool names #1081 is open, non-draft, authored by another account, and this review was made against the current head.
• I did not find any earlier MRWK bounty: 40 MRWK - review open MergeWork PRs with evidence, round 21 #1009 claim for PR Surface static did-you-mean suggestions for unknown MCP tool names #1081 before this submission.

Payout boundary: this is a submitted #1009 review-bounty claim only. It is not earned, accepted, pending, or withdrawable unless maintainers accept it and record proof-backed payment.

[modelsbridgeaicom-ship-it]

/claim

Review bounty claim for #1009.

Reviewed PR: #1062
Review submitted: #1062 (review)
Reviewed head: 5fd1f25

Scope checked:

• Verified the shared query-validation helper still allows optional detail guidance.
• Confirmed account pages reject unsupported type/tx_type query parameters as intended while preserving account JSON behavior.
• Rechecked the earlier closing-reference concern; current PR body references Bounty #936 and does not auto-close it.

Validation run on the reviewed head:

• python -m pytest tests\test_query_validation.py tests\test_account_routes.py -k "transaction_type or account_action_urls_escape_query_accounts or unsupported_query_params" -q -> 4 passed, 12 deselected, 1 warning
• python -m pytest tests\test_query_validation.py tests\test_account_routes.py -q -> 16 passed, 1 warning
• ruff check app\query_validation.py app\accounts.py tests\test_query_validation.py tests\test_account_routes.py -> pass
• ruff format --check app\query_validation.py app\accounts.py tests\test_query_validation.py tests\test_account_routes.py -> 4 files already formatted
• python -m mypy app\accounts.py app\query_validation.py -> success
• python scripts\docs_smoke.py -> docs smoke ok
• git diff --check origin/main...HEAD and git diff --check -> clean
• git merge-tree --write-tree origin/main HEAD -> clean tree 90702e132c3ddcbaa9d059da551d9b375588901b

Verdict: approved as merge-ready for the checked account/query-validation surface.

[modelsbridgeaicom-ship-it]

/claim

Submitted a current-head review for a third-party PR under this bounty:

• PR: Link contributor account routes from /me #1092
• Review: Link contributor account routes from /me #1092 (review)
• Reviewed head: 6c68680906d02ccd0c7b0ec90e16a288d7603e2e

Review verdict:

• Approved as merge-ready for the checked /me account navigation surface.
• Inspected app/templates/me.html and tests/test_wallet_api.py.
• Confirmed signed-in /me links route to the user's github:* ledger account, account-filtered activity view, and linked wallet only when a wallet is linked.
• Checked the github_login source path through GitHub OAuth and the signed mrwk_user cookie, and compared existing repository route patterns for /accounts/github:<login>.
• Reviewed Copilot's comments; URL helper / semantic nav polish is useful follow-up, but not a merge blocker for this focused GitHub-login navigation change.

Validation run on exact PR head:

• python -m pytest tests\test_wallet_api.py::test_me_page_shows_signed_in_github_claim_balance tests\test_wallet_api.py::test_me_page_links_linked_wallet tests\test_wallet_api.py::test_me_page_prefills_claim_address_for_linked_wallet -q -> 3 passed, 1 existing Starlette/httpx warning.
• python -m pytest tests\test_wallet_api.py -q -> 46 passed, 1 existing warning.
• python -m pytest tests\test_wallet_api.py tests\test_me_page.py -q -> 48 passed, 1 existing warning.
• ruff check tests\test_wallet_api.py tests\test_me_page.py -> pass.
• ruff format --check tests\test_wallet_api.py tests\test_me_page.py -> 2 files already formatted.
• python scripts\docs_smoke.py -> docs smoke ok.
• git diff --check origin/main...HEAD -> clean.
• git merge-tree --write-tree origin/main HEAD -> clean tree 3dfac861723728e00ca56af7ac61edad3b461a47.
• GitHub CI Quality, readiness, docs, and image checks -> pass.
• CodeRabbit -> pass / review skipped.

Eligibility:

• PR Link contributor account routes from /me #1092 is open, non-draft, authored by another account, and this review was made against the current head.
• I did not find any earlier MRWK bounty: 40 MRWK - review open MergeWork PRs with evidence, round 21 #1009 claim for PR Link contributor account routes from /me #1092 before this submission.

Payout boundary: this is a submitted #1009 review-bounty claim only. It is not earned, accepted, pending, or withdrawable unless maintainers accept it and record proof-backed payment.

[modelsbridgeaicom-ship-it]

/claim

Submitted a current-head review for a third-party PR under this bounty:

• PR: docs: add PR review guide for bounty round 20 (#933) #1039
• Review: docs: add PR review guide for bounty round 20 (#933) #1039 (review)
• Reviewed head: 606bdf38a9e8c2c886509b240d7f7a60721b1023

Review verdict:

• CHANGES_REQUESTED / needs-info for bounty scope.
• The docs patch is narrow and link-valid, but it should not be accepted or paid as a MRWK bounty: 40 MRWK - review open MergeWork PRs with evidence, round 20 #933 bounty claim because MRWK bounty: 40 MRWK - review open MergeWork PRs with evidence, round 20 #933 is a review-bounty round, not a docs-guide implementation bounty.
• Author needs to clarify non-bounty status or point the PR at a live bounty/scope that covers review-guide documentation.

Evidence checked:

• Inspected CONTRIBUTING.md and docs/pr-review-guide.md.
• Confirmed GitHub/local diff contains only those two docs files: 31 inserted lines total.
• Confirmed CONTRIBUTING.md links to docs/pr-review-guide.md, and the guide links back to ../CONTRIBUTING.md.
• Checked PR state: open, non-draft, mergeStateStatus=UNSTABLE, mrwk:needs-info, CodeRabbit success with description/bounty-focus warnings.
• Confirmed MRWK bounty: 40 MRWK - review open MergeWork PRs with evidence, round 20 #933 is a live review bounty, not a docs-guide implementation bounty.

Validation:

• python scripts\docs_smoke.py -> docs smoke ok.
• git diff --name-only origin/main...HEAD -> CONTRIBUTING.md, docs/pr-review-guide.md.
• git merge-tree --write-tree origin/main HEAD -> clean tree f9af6ff5a34dd246522d11c0533a47157cabafc4.
• git diff --check origin/main...HEAD -> clean.

Scope: review evidence only. No private data, wallet material, payout execution, treasury mutation, exchange, bridge, cash-out, or MRWK price behavior involved.