From ddf1c8f0b9ba75954f4fdefb800c2dd41ef1781c Mon Sep 17 00:00:00 2001 From: Tarang Jain <40517122+tarang-jain@users.noreply.github.com> Date: Wed, 5 Feb 2025 13:27:38 +0530 Subject: [PATCH] cuvs-bench Fixes (#654) - Simple bug fix for seg fault while running cuvs-bench - Pin the correct FAISS version for cuvs-bench Authors: - Tarang Jain (https://github.com/tarang-jain) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Artem M. Chirkin (https://github.com/achirkin) URL: https://github.com/rapidsai/cuvs/pull/654 --- cpp/bench/ann/src/common/benchmark.hpp | 2 +- cpp/cmake/patches/faiss_override.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpp/bench/ann/src/common/benchmark.hpp b/cpp/bench/ann/src/common/benchmark.hpp index 9653a589b..d2b3f89ff 100644 --- a/cpp/bench/ann/src/common/benchmark.hpp +++ b/cpp/bench/ann/src/common/benchmark.hpp @@ -571,7 +571,7 @@ void dispatch_benchmark(std::string cmdline, } } std::swap(more_indices, indices); // update the config in case algorithms need to access it - register_build(dataset, more_indices, force_overwrite, no_lap_sync); + register_build(dataset, indices, force_overwrite, no_lap_sync); } else if (search_mode) { if (file_exists(query_file)) { log_info("Using the query file '%s'", query_file.c_str()); diff --git a/cpp/cmake/patches/faiss_override.json b/cpp/cmake/patches/faiss_override.json index 18542fcf5..c211f4455 100644 --- a/cpp/cmake/patches/faiss_override.json +++ b/cpp/cmake/patches/faiss_override.json @@ -1,9 +1,9 @@ { "packages" : { "faiss" : { - "version": "1.7.4", + "version": "1.10.0", "git_url": "https://github.com/facebookresearch/faiss.git", - "git_tag": "main" + "git_tag": "v1.10.0" } } }