Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "MetricObjective" needs to be plumbed through algorithms in cuvs-bench #739

Open
cjnolet opened this issue Mar 1, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@cjnolet
Copy link
Member

cjnolet commented Mar 1, 2025

It looks like when cuvs-bench was migrated from RAFT, the metric objective (latency vs throughput) was broken. See this line of code, which was added to cuvs-bench but doesn't exist in the raft-ann-bench, for example. We need to fix this.

cc @achirkin @divyegala

@cjnolet cjnolet added the bug Something isn't working label Mar 1, 2025
@achirkin
Copy link
Contributor

achirkin commented Mar 3, 2025

I believe the bench_mode_ variable in HNSW is not needed once #724 is merged. The only other algorithm that has such a variable is diskann, but it is also not used there at all.

In any case, this information can be obtained in any algorithm by comparing cuvs::bench::benchmark_n_threads global variable to 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants