RDBC-944 Replace undefined checks with null checks across AI settings validation logic for consistency and improved readability.

Author: M4xymm

src/Documents/Operations/AI/ConnectionStrings/Settings/AzureOpenAiSettings.ts

@@ -22,7 +22,7 @@ export class AzureOpenAiSettings extends OpenAiBaseSettings {
     public validate(errors: string[]): void {
         super.validate(errors);
 
-        if (StringUtil.isNullOrEmpty(this.deploymentName.trim())) {
+        if (StringUtil.isNullOrEmpty(this.deploymentName?.trim())) {
             errors.push("Value for 'deploymentName' field cannot be empty.");
         }
     }

src/Documents/Operations/AI/ConnectionStrings/Settings/GoogleSettings.ts

@@ -55,7 +55,7 @@ export class GoogleSettings extends AbstractAiSettings {
             errors.push("Value of 'apiKey' field cannot be empty.");
         }
 
-        if (this.dimensions !== undefined && this.dimensions <= 0) {
+        if (this.dimensions != null && this.dimensions <= 0) {
             errors.push("Value of 'dimensions' field must be positive.");
         }
     }

src/Documents/Operations/AI/ConnectionStrings/Settings/OllamaSettings.ts

@@ -47,7 +47,7 @@ export class OllamaSettings extends AbstractAiSettings {
             errors.push("Value of 'model' field cannot be empty.");
         }
 
-        if (this.temperature !== undefined && this.temperature < 0) {
+        if (this.temperature != null && this.temperature < 0) {
             errors.push("Value of 'temperature' field must be non-negative.");
         }
     }
@@ -71,12 +71,12 @@ export class OllamaSettings extends AbstractAiSettings {
             differences |= AiSettingsCompareDifferences.EndpointConfiguration;
         }
 
-        const hasTemperature = this.temperature !== undefined;
-        const otherHasTemperature = other.temperature !== undefined;
+        const hasTemperature = this.temperature != null;
+        const otherHasTemperature = other.temperature != null;
 
         if (hasTemperature !== otherHasTemperature ||
             (hasTemperature && otherHasTemperature &&
-             Math.abs(this.temperature! - other.temperature!) > 0.0001)) {
+             Math.abs(this.temperature - other.temperature) > 0.0001)) {
             differences |= AiSettingsCompareDifferences.EndpointConfiguration;
         }
 

src/Documents/Operations/AI/ConnectionStrings/Settings/OpenAiBaseSettings.ts

@@ -71,11 +71,11 @@ export abstract class OpenAiBaseSettings extends AbstractAiSettings implements I
             errors.push("Value of 'model' field cannot be empty.");
         }
 
-        if (this.dimensions !== undefined && this.dimensions <= 0) {
+        if (this.dimensions != null && this.dimensions <= 0) {
             errors.push("Value of 'dimensions' field must be positive.");
         }
 
-        if (this.temperature !== undefined && this.temperature < 0) {
+        if (this.temperature != null && this.temperature < 0) {
             errors.push("Value of 'temperature' field must be non-negative.");
         }
     }
@@ -103,12 +103,12 @@ export abstract class OpenAiBaseSettings extends AbstractAiSettings implements I
             differences |= AiSettingsCompareDifferences.EmbeddingDimensions;
         }
 
-        const hasTemperature = this.temperature !== undefined;
-        const otherHasTemperature = other.temperature !== undefined;
+        const hasTemperature = this.temperature != null;
+        const otherHasTemperature = other.temperature != null;
 
         if (hasTemperature !== otherHasTemperature ||
             (hasTemperature && otherHasTemperature &&
-             Math.abs(this.temperature! - other.temperature!) > 0.0001)) {
+             Math.abs(this.temperature - other.temperature) > 0.0001)) {
             differences |= AiSettingsCompareDifferences.EndpointConfiguration;
         }