Skip to content

[Feature] Configure operations timeout for apiserver HTTP server #3306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 2 tasks
dentiny opened this issue Apr 11, 2025 · 2 comments · May be fixed by #3350
Open
1 of 2 tasks

[Feature] Configure operations timeout for apiserver HTTP server #3306

dentiny opened this issue Apr 11, 2025 · 2 comments · May be fixed by #3350
Assignees
@owenowenisme
Labels
apiserver enhancement New feature or request P2 Important issue, but not time critical

Comments

@dentiny
Copy link
Contributor

dentiny commented Apr 11, 2025

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

kuberay/apiserver/cmd/main.go

Lines 138 to 149 in 099bf61

// Create a top level mux to include both Http gRPC servers and other endpoints like metrics
topMux := http.NewServeMux()
// Seems /apis (matches /apis/v1alpha1/clusters) works fine
topMux.Handle("/", runtimeMux)
topMux.Handle("/metrics", promhttp.Handler())
topMux.HandleFunc("/swagger/", serveSwaggerFile)
topMux.HandleFunc("/healthz", serveHealth)
serveSwaggerUI(topMux)
if err := http.ListenAndServe(*httpPortFlag, topMux); err != nil {
klog.Fatal(err)
}

golangci-lint suggests timeout configuration.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@dentiny dentiny added enhancement New feature or request P2 Important issue, but not time critical labels Apr 11, 2025
@dentiny dentiny changed the title [Feature] Configure operations timeout for HTTP server [Feature] Configure operations timeout for apiserver HTTP server Apr 11, 2025
@owenowenisme
Copy link
Contributor

@dentiny
May I work on this?

@dentiny
Copy link
Contributor Author

dentiny commented Apr 12, 2025 •
edited
Loading

@dentiny May I work on this?

Sure! Assigned. Thank you for the help!

@dentiny dentiny mentioned this issue Apr 13, 2025
Merged
4 tasks
@owenowenisme owenowenisme linked a pull request Apr 13, 2025 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owenowenisme owenowenisme

Labels
apiserver enhancement New feature or request P2 Important issue, but not time critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[apiserver][feat] Add read and write timeouts to HTTP server owenowenisme/kuberay
2 participants
@dentiny @owenowenisme