[e2e] add ray service runtime env update e2e test #4225
+66
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
e2e test ci failed, plz fix it. |
Author
|
Please don't review for now. It's still wip. Will be investigate it further. |
ryankert01
force-pushed
the
e2e/ray-service-runtime-env-update
branch
from
5c05505 to
b4cd1e2
Compare
Signed-off-by: Ryan <[email protected]>
Signed-off-by: Ryan <[email protected]>
ryankert01
force-pushed
the
e2e/ray-service-runtime-env-update
branch
2 times, most recently
from
95d58a8 to
3145953
Compare
Signed-off-by: Ryan <[email protected]>
ryankert01
changed the title
Signed-off-by: Ryan Huang <[email protected]>
Removed worker group spec and related verification for auth token propagation in RayService tests. Signed-off-by: Ryan Huang <[email protected]>
Author
|
@400Ping PTAL |
400Ping
reviewed
Nov 29, 2025
Comment on lines
+62
to
+65
| // Clean up the RayService | ||
| err = test.Client().Ray().RayV1().RayServices(namespace.Name).Delete(test.Ctx(), rayService.Name, metav1.DeleteOptions{}) | ||
| g.Expect(err).NotTo(HaveOccurred()) | ||
| LogWithTimestamp(test.T(), "Deleted RayService %s/%s successfully", rayService.Namespace, rayService.Name) |
Contributor
There was a problem hiding this comment.
Consider using defer for the RayService cleanup so we still delete it when an earlier expectation fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
AuthModeTokenenabledRAY_AUTH_MODEandRAY_AUTH_TOKENenvironment variables are correctly set in head podSecretKeyRefwith the correct keyKey implementation details:
RayServiceSampleYamlApplyConfiguration()and adds auth options and a worker group programmatically (no separate YAML file needed)VerifyContainerAuthTokenEnvVars()helper fromtest/support/ray.goRelated issue number
Related to #4203
Checks