[RLlib] Merge tuned examples into examples #58893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2025 17:06
Signed-off-by: Mark Towers <[email protected]>
Signed-off-by: Mark Towers <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the repository by merging the tuned_examples directory into the examples directory, aiming for a simpler project structure. The changes primarily consist of moving files and updating their paths in the rllib/BUILD.bazel file. While most of the path updates are correct, I've identified a critical issue where one of the test configurations points to an incorrect file path, which will cause the test to fail. Additionally, I've found a minor, pre-existing issue in a commented-out test that could be addressed now to prevent future problems. Overall, this is a positive structural change for the repository.
added 2 commits
November 21, 2025 18:12
Signed-off-by: Mark Towers <[email protected]>
# Conflicts: # rllib/BUILD.bazel
pseudo-rnd-thoughts
added
rllib
added 2 commits
November 24, 2025 11:06
Signed-off-by: Mark Towers <[email protected]>
Signed-off-by: Mark Towers <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: Mark Towers <[email protected]>
kamil-kaczmarek
changed the title
rllib/BUILD.bazel
Outdated
| # | ||
| # This will test python/yaml config files | ||
| # inside rllib/tuned_examples/[algo-name] for actual learning success. | ||
| # inside rllib/examples/algorithm/[algo-name] for actual learning success. |
Contributor
There was a problem hiding this comment.
Suggested change
| # inside rllib/examples/algorithm/[algo-name] for actual learning success. | |
| # inside rllib/examples/algorithms/[algo-name] for actual learning success. |
kamil-kaczmarek
requested changes
Nov 25, 2025
Contributor
kamil-kaczmarek
left a comment
kamil-kaczmarek
left a comment
There was a problem hiding this comment.
Great!
I left few minor requests for edits.
added 4 commits
November 26, 2025 11:12
# Conflicts: # rllib/BUILD.bazel # rllib/examples/algorithms/bc/cartpole_bc.py # rllib/examples/algorithms/bc/cartpole_bc_with_offline_evaluation.py # rllib/examples/algorithms/bc/pendulum_bc.py # rllib/examples/algorithms/iql/pendulum_iql.py # rllib/examples/algorithms/marwil/cartpole_marwil.py
Signed-off-by: Mark Towers <[email protected]>
Signed-off-by: Mark Towers <[email protected]>
Signed-off-by: Mark Towers <[email protected]>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
## Description RLlib has a tuned-examples and examples folder however we believe this is a confusing structure which this PR merges Therefore, this PR moves all tuned-example scripts into `examples/algorithms` for the new stack api and `examples/_old_api_stack/algorithms` for the old stack api. --------- Signed-off-by: Mark Towers <[email protected]> Co-authored-by: Mark Towers <[email protected]> Co-authored-by: Kamil Kaczmarek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RLlib has a tuned-examples and examples folder however we believe this is a confusing structure which this PR merges
Therefore, this PR moves all tuned-example scripts into
examples/algorithmsfor the new stack api andexamples/_old_api_stack/algorithmsfor the old stack api.