Update appcleaner extension #17115
Open
Update appcleaner extension #17115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes app icon finding crash - Merge branch \'contributions/merge-1739747587815\' - Pull contributions - Merge branch \'contributions/merge-1739747490405\' - Pull contributions - Merge branch \'contributions/merge-1739747471183\' - Pull contributions
raycastbot
added
extension fix / improvement
|
Thank you for the update! 🎉 Due to our current reduced availability, the initial review may take up to 10-15 business days |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the AppCleaner extension's icon handling capabilities by implementing robust fallback mechanisms for applications with non-standard folder structures.
- Added comprehensive icon path fallbacks in
src/lib/app-utils.tsto handle apps without standard/Contents/Resourcesstructure - Improved icon file detection with support for both
.icnsand.pngformats using regex patterns - Simplified app filtering logic in
src/lib/app-manager.tsby moving system app checks earlier in the process - Enhanced error handling for file system operations when scanning application directories
- Updated PearCleaner attribution in README with proper GitHub links
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
6 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder