fix!: DH-19970, DH-19958: Make it harder to accidentally create unpooled chunks, refactor pooling code to improve giving pattern, and make poolable capacities configurable (deephaven#7060)

Author: rcaudy

BenchmarkSupport/BenchmarkSupport.gradle

@@ -25,8 +25,8 @@ dependencies {
     testImplementation project(':engine-test-utils')
     testImplementation project(path: ':Base', configuration: 'tests')
 
-    testRuntimeOnly project(path: ':configs')
-    testRuntimeOnly project(path: ':test-configs')
+    testRuntimeOnly project(':configs')
+    testRuntimeOnly project(':test-configs')
     testRuntimeOnly project(':Numerics')
 
     testRuntimeOnly project(':log-to-slf4j')

ClientSupport/ClientSupport.gradle

@@ -15,7 +15,7 @@ dependencies {
     testImplementation libs.assertj
 
     testRuntimeOnly project(':log-to-slf4j'),
-            project(path: ':configs'),
-            project(path: ':test-configs')
+            project(':configs'),
+            project(':test-configs')
     testRuntimeOnly libs.slf4j.simple
 }

Generators/Generators.gradle

@@ -20,17 +20,17 @@ dependencies {
     implementation libs.groovy
     implementation libs.groovy.json
 
-    runtimeOnly project(path: ':configs')
-    runtimeOnly project(path: ':test-configs')
+    runtimeOnly project(':configs')
+    runtimeOnly project(':test-configs')
     runtimeOnly project(':extensions-kafka')
 
     runtimeOnly project(':log-to-slf4j')
     runtimeOnly libs.logback.classic
 
     testImplementation project(path: ':Base', configuration: 'tests')
 
-    testRuntimeOnly project(path: ':configs')
-    testRuntimeOnly project(path: ':test-configs')
+    testRuntimeOnly project(':configs')
+    testRuntimeOnly project(':test-configs')
 
     combinedJavadoc project(path: ':combined-javadoc', targetConfiguration: 'combinedJavadoc')
 }

Numerics/Numerics.gradle

@@ -12,11 +12,9 @@ dependencies {
 
     testImplementation project(':base-test-utils')
     testImplementation project(path: ':Base', configuration: 'tests')
-    testRuntimeOnly project(path: ':configs')
-    testRuntimeOnly project(path: ':test-configs')
+    testRuntimeOnly project(':configs')
+    testRuntimeOnly project(':test-configs')
 
-    testRuntimeOnly project(':log-to-slf4j'),
-            project(path: ':configs'),
-            project(path: ':test-configs')
+    testRuntimeOnly project(':log-to-slf4j')
     testRuntimeOnly libs.slf4j.simple
 }

TableLogger/TableLogger.gradle

@@ -6,10 +6,10 @@ dependencies {
     implementation project(':Base')
     implementation project(':Util')
     implementation project(":util-pool")
-    testRuntimeOnly project(path: ':configs')
-    testRuntimeOnly project(path: ':test-configs')
+    testRuntimeOnly project(':configs')
+    testRuntimeOnly project(':test-configs')
 
-    runtimeOnly project(path: ':configs')
+    runtimeOnly project(':configs')
 
     testRuntimeOnly project(':log-to-slf4j')
     testRuntimeOnly libs.slf4j.simple

Util/Util.gradle

@@ -12,8 +12,8 @@ dependencies {
 
     implementation project(':Configuration')
 
-    testRuntimeOnly project(path: ':configs')
-    testRuntimeOnly project(path: ':test-configs')
+    testRuntimeOnly project(':configs')
+    testRuntimeOnly project(':test-configs')
 
     testRuntimeOnly project(':log-to-slf4j')
     testRuntimeOnly libs.slf4j.simple

engine/benchmark/build.gradle

@@ -23,8 +23,8 @@ dependencies {
     testAnnotationProcessor libs.jmh.generator.annprocess
     testCompileOnly libs.jmh.generator.annprocess
 
-    testRuntimeOnly project(path: ':configs')
-    testRuntimeOnly project(path: ':test-configs')
+    testRuntimeOnly project(':configs')
+    testRuntimeOnly project(':test-configs')
 }
 
 task jmhRun(type: JavaExec)  {

engine/chunk/build.gradle

@@ -10,11 +10,12 @@ dependencies {
     api project(':Util')
     api project(':codec-api:')
     implementation project(':Base')
+    implementation project(':Configuration')
 
     testImplementation libs.junit4
 
     testRuntimeOnly project(':log-to-slf4j')
-    testRuntimeOnly project(path: ':configs')
-    testRuntimeOnly project(path: ':test-configs')
+    testRuntimeOnly project(':configs')
+    testRuntimeOnly project(':test-configs')
     testRuntimeOnly libs.slf4j.simple
 }

engine/chunk/src/main/java/io/deephaven/chunk/ResettableBooleanChunk.java

@@ -27,20 +27,11 @@ public static <ATTR_BASE extends Any> ResettableBooleanChunk<ATTR_BASE> makeRese
         return new ResettableBooleanChunk<>();
     }
 
-    public static <ATTR_BASE extends Any> ResettableBooleanChunk<ATTR_BASE> makeResettableChunkForPool() {
-        return new ResettableBooleanChunk<>() {
-            @Override
-            public void close() {
-                MultiChunkPool.forThisThread().giveResettableBooleanChunk(this);
-            }
-        };
-    }
-
     private ResettableBooleanChunk(boolean[] data, int offset, int capacity) {
         super(data, offset, capacity);
     }
 
-    private ResettableBooleanChunk() {
+    protected ResettableBooleanChunk() {
         this(ArrayTypeUtils.EMPTY_BOOLEAN_ARRAY, 0, 0);
     }
 

engine/chunk/src/main/java/io/deephaven/chunk/ResettableByteChunk.java

@@ -27,20 +27,11 @@ public static <ATTR_BASE extends Any> ResettableByteChunk<ATTR_BASE> makeResetta
         return new ResettableByteChunk<>();
     }
 
-    public static <ATTR_BASE extends Any> ResettableByteChunk<ATTR_BASE> makeResettableChunkForPool() {
-        return new ResettableByteChunk<>() {
-            @Override
-            public void close() {
-                MultiChunkPool.forThisThread().giveResettableByteChunk(this);
-            }
-        };
-    }
-
     private ResettableByteChunk(byte[] data, int offset, int capacity) {
         super(data, offset, capacity);
     }
 
-    private ResettableByteChunk() {
+    protected ResettableByteChunk() {
         this(ArrayTypeUtils.EMPTY_BYTE_ARRAY, 0, 0);
     }