Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quad and Term Problems #9

Open
jaxoncreed opened this issue May 5, 2021 · 3 comments
Open

Quad and Term Problems #9

jaxoncreed opened this issue May 5, 2021 · 3 comments

Comments

@jaxoncreed
Copy link
Contributor

There seems to be a few things that deviate from the spec:

1. BaseQuad is not a Term

In the "Data Interfaces" section of the spec (https://rdf.js.org/data-model-spec/#data-interfaces) Quad is does not extend term, however, in the typings it does: https://github.com/rdfjs/types/blob/master/data-model.d.ts#L13

2. Quad equals accepts Term instead of Quad

In the "Quad Interface" section of the spec (https://rdf.js.org/data-model-spec/#quad-interface) a Quad is the parameter for equals, but in the typings, Term is the parameter (https://github.com/rdfjs/types/blob/master/data-model.d.ts#L13)

@rubensworks
Copy link
Member

All of this is actually intentional, see rdfjs/data-model-spec#165

@jaxoncreed
Copy link
Contributor Author

Okay then, I guess this is more about inconsistencies in the spec then. Is there a reason the places I linked say Quad rather than Term?

@rubensworks
Copy link
Member

Is there a reason the places I linked say Quad rather than Term?

Not really, just needs an update I guess.
Feel free to submit a PR! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants