Skip to content

Commit e7fe37c

Browse files
committed
upgrade rc-tools
1 parent 0a46f2c commit e7fe37c

18 files changed

+55
-105
lines changed

.gitignore

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,8 @@ Thumbs.db
1919
*.pyo
2020
.build
2121
node_modules
22-
_site
23-
sea-modules
24-
spm_modules
2522
.cache
2623
dist
2724
assets/**/*.css
28-
examples/**/*.css
29-
build
25+
build
26+
lib

.jscsrc

Lines changed: 0 additions & 27 deletions
This file was deleted.

.jshintrc

Lines changed: 0 additions & 28 deletions
This file was deleted.

.npmignore

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
bower_components/
1+
build/
22
*.cfg
3-
node_modules/
43
nohup.out
54
*.iml
65
.idea/
@@ -21,9 +20,10 @@ Thumbs.db
2120
out/
2221
.build
2322
node_modules
24-
_site
25-
sea-modules
26-
spm_modules
2723
.cache
28-
dist
29-
build
24+
examples
25+
tests
26+
src
27+
/index.js
28+
.*
29+
assets/**/*.less

examples/multiple.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
/** @jsx React.DOM */
1+
'use strict';
2+
23
var React = require('react');
34
var Menu = require('rc-menu');
45
var SubMenu = Menu.SubMenu;

examples/scrollable.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
/** @jsx React.DOM */
1+
'use strict';
2+
23
var React = require('react');
34
var Menu = require('rc-menu');
45
var SubMenu = Menu.SubMenu;

examples/single.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
/** @jsx React.DOM */
1+
'use strict';
2+
23
var React = require('react');
34
var Menu = require('rc-menu');
45
var SubMenu = Menu.SubMenu;

examples/top.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
/** @jsx React.DOM */
1+
'use strict';
2+
23
var React = require('react');
34
var Menu = require('rc-menu');
45
var SubMenu = Menu.SubMenu;
@@ -20,7 +21,7 @@ var style = `
2021
zoom:1;
2122
}
2223
.rc-top-menu:after {
23-
content:"\20";
24+
content:"\\20";
2425
display:block;
2526
height:0;
2627
clear:both;

index.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1 @@
1-
var Menu = require('./lib/Menu');
2-
Menu.SubMenu = require('./lib/SubMenu');
3-
Menu.Item = require('./lib/MenuItem');
4-
module.exports = Menu;
1+
module.exports = require('./src/');

package.json

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "rc-menu",
3-
"version": "3.2.1",
3+
"version": "3.2.2",
44
"description": "menu ui component for react",
55
"keywords": [
66
"react",
@@ -22,23 +22,17 @@
2222
"url": "http://github.com/react-component/menu/issues"
2323
},
2424
"licenses": "MIT",
25-
"spm": {
26-
"dependencies": {
27-
"react": "*",
28-
"rc-util": "2.x",
29-
"dom-scroll-into-view": "^1.0.1"
30-
}
31-
},
3225
"config": {
3326
"port": 8000
3427
},
3528
"scripts": {
3629
"build": "rc-tools run build",
30+
"precommit": "rc-tools run precommit",
3731
"less": "rc-tools run less",
3832
"gh-pages": "rc-tools run gh-pages",
3933
"history": "rc-tools run history",
4034
"start": "node --harmony node_modules/.bin/rc-server",
41-
"publish": "rc-tools run tag && spm publish",
35+
"publish": "rc-tools run tag",
4236
"lint": "rc-tools run lint",
4337
"saucelabs": "node --harmony node_modules/.bin/rc-tools run saucelabs",
4438
"browser-test": "node --harmony node_modules/.bin/rc-tools run browser-test",
@@ -51,16 +45,15 @@
5145
"gregorian-calendar-format": "^2.1.1",
5246
"precommit-hook": "^1.0.7",
5347
"rc-calendar": "^1.5.8",
54-
"rc-server": "^2.0.0",
55-
"rc-tools": "2.x",
48+
"rc-server": "3.x",
49+
"rc-tools": "3.x",
5650
"react": "~0.13.0"
5751
},
5852
"dependencies": {
5953
"dom-scroll-into-view": "^1.0.1",
6054
"rc-util": "2.x"
6155
},
6256
"precommit": [
63-
"lint",
64-
"less"
57+
"precommit"
6558
]
6659
}

lib/Menu.jsx renamed to src/Menu.jsx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
'use strict';
2+
13
var React = require('react');
24
var rcUtil = require('rc-util');
35
var joinClasses = rcUtil.joinClasses;
@@ -93,6 +95,7 @@ class Menu extends React.Component {
9395
case KeyCode.DOWN: //down
9496
activeKey = this.step(1);
9597
break;
98+
default:
9699
}
97100
if (activeKey) {
98101
e.preventDefault();
@@ -116,16 +119,16 @@ class Menu extends React.Component {
116119
}
117120
// find current activeIndex
118121
var activeIndex = -1;
119-
children.every((c, i)=> {
122+
children.every((c, ci)=> {
120123
if (c.key === activeKey) {
121-
activeIndex = i;
124+
activeIndex = ci;
122125
return false;
123126
}
124127
return true;
125128
});
126129
var start = (activeIndex + 1) % len;
127130
var i = start;
128-
while (1) {
131+
for (;;) {
129132
var child = children[i];
130133
var key = child.key;
131134
if (child.props.disabled) {
@@ -239,8 +242,8 @@ class Menu extends React.Component {
239242
classes[props.prefixCls] = true;
240243
var domProps = {
241244
className: joinClasses(props.className, classSet(classes)),
242-
role: "menu",
243-
"aria-activedescendant": ""
245+
role: 'menu',
246+
'aria-activedescendant': ''
244247
};
245248
if (props.id) {
246249
domProps.id = props.id;

lib/MenuItem.jsx renamed to src/MenuItem.jsx

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
'use strict';
2+
13
var React = require('react');
24
var rcUtil = require('rc-util');
35
var joinClasses = rcUtil.joinClasses;
@@ -55,11 +57,10 @@ class MenuItem extends React.Component {
5557
} else {
5658
props.onSelect(eventKey, this, e);
5759
}
58-
} else {
59-
if (!props.selected) {
60-
props.onSelect(eventKey, this, e);
61-
}
60+
} else if (!props.selected) {
61+
props.onSelect(eventKey, this, e);
6262
}
63+
6364
}
6465

6566
componentWillUnmount() {
@@ -79,9 +80,9 @@ class MenuItem extends React.Component {
7980
var attrs = {
8081
title: props.title,
8182
className: joinClasses(props.className, classSet(classes)),
82-
role: "menuitem",
83-
"aria-selected": props.selected,
84-
"aria-disabled": props.disabled
83+
role: 'menuitem',
84+
'aria-selected': props.selected,
85+
'aria-disabled': props.disabled
8586
};
8687
var mouseEvent = {};
8788
if (!props.disabled) {

lib/SubMenu.jsx renamed to src/SubMenu.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
'use strict';
2+
13
var React = require('react');
24
var rcUtil = require('rc-util');
35
var joinClasses = rcUtil.joinClasses;
@@ -81,7 +83,7 @@ var SubMenu = React.createClass({
8183
if (this.state.open) {
8284
handled = menu.handleKeyDown(e);
8385
} else {
84-
return;
86+
return undefined;
8587
}
8688
if (!handled) {
8789
this.setOpenState(false);

lib/SubMenuStateMixin.jsx renamed to src/SubMenuStateMixin.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
'use strict';
2+
13
var rcUtil = require('rc-util');
24
var KeyCode = rcUtil.KeyCode;
35
var React = require('react');

src/index.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
'use strict';
2+
3+
var Menu = require('./Menu');
4+
Menu.SubMenu = require('./SubMenu');
5+
Menu.Item = require('./MenuItem');
6+
module.exports = Menu;

tests/Menu.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/** @jsx React.DOM */
1+
'use strict';
22

33
var expect = require('expect.js');
44
var React = require('react/addons');

tests/MenuItem.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/** @jsx React.DOM */
1+
'use strict';
22

33
var expect = require('expect.js');
44
var React = require('react/addons');

tests/index.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/** @jsx React.DOM */
1+
'use strict';
22

33
require('/assets/index.css');
44
require('./Menu.spec');

0 commit comments

Comments
 (0)