Skip to content

Commit 44fe8ff

Browse files
authored
feat: improve new release checker CTA and logic (#1716)
* change the wording * add small bit of logic to avoid checking for nightlies and such * lint
1 parent e89f296 commit 44fe8ff

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

packages/cli-tools/src/releaseChecker/getLatestRelease.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,15 @@ export default async function getLatestRelease(
2424
try {
2525
logger.debug(`Current version: ${currentVersion}`);
2626

27+
// if the version is a 1000.0.0 version or 0.0.0, we want to bail
28+
// since they are nightlies or unreleased versions
29+
if (
30+
currentVersion.includes('1000.0.0') ||
31+
currentVersion.includes('0.0.0')
32+
) {
33+
return;
34+
}
35+
2736
const cachedLatest = cacheManager.get(name, 'latestVersion');
2837

2938
if (cachedLatest) {

packages/cli-tools/src/releaseChecker/printNewRelease.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@ export default function printNewRelease(
1616
);
1717
logger.info(`Changelog: ${chalk.dim.underline(latestRelease.changelogUrl)}`);
1818
logger.info(`Diff: ${chalk.dim.underline(latestRelease.diffUrl)}`);
19-
logger.info(`To upgrade, run "${chalk.bold('react-native upgrade')}".`);
19+
logger.info(
20+
`For more info, check out "${chalk.dim.underline(
21+
'https://reactnative.dev/docs/upgrading',
22+
)}".`,
23+
);
2024

2125
cacheManager.set(name, 'lastChecked', new Date().toISOString());
2226
}

0 commit comments

Comments
 (0)