Skip to content

Commit 47be0cb

Browse files
committed
Fix text alignment in multiline Alerts
1 parent 2464055 commit 47be0cb

File tree

9 files changed

+18
-16
lines changed

9 files changed

+18
-16
lines changed

demo/generated/demo.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/lib.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@react-ui-org/react-ui",
3-
"version": "0.22.0",
3+
"version": "0.22.1",
44
"license": "MIT",
55
"main": "dist/lib.js",
66
"repository": {

src/lib/components/ui/Alert/Alert.scss

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,20 @@
55
}
66

77
.icon {
8-
position: absolute;
9-
left: $alert-offset;
8+
position: relative;
9+
top: 1px;
1010
display: flex;
1111
flex-direction: column;
1212
align-items: center;
13+
align-self: flex-start;
1314
justify-content: flex-start;
14-
height: 100%;
15-
padding-top: calc((#{$alert-min-height} - (2 * #{$alert-border-width}) - #{$alert-icon-size}) / 2);
1615
}
1716

1817
.message {
19-
padding-left: $alert-offset;
18+
padding-left: $alert-padding;
2019
font-weight: $alert-message-font-weight;
20+
font-size: $alert-font-size;
2121
line-height: $alert-line-height;
22-
23-
&:not(:first-child) {
24-
padding-left: calc(#{$alert-icon-size} + #{$alert-offset});
25-
}
2622
}
2723

2824
.message strong {

src/lib/components/ui/Alert/_mixins.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
align-items: center;
99
width: 100%;
1010
min-height: $alert-min-height;
11-
padding: $alert-offset;
11+
padding: $alert-padding;
1212
border-width: $alert-border-width $alert-border-width $alert-border-width $alert-stripe-width;
1313
border-style: solid;
1414
border-radius: $alert-border-radius;

src/lib/components/ui/Alert/_theme.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
$alert-border-width: var(--rui-alert-border-width);
22
$alert-border-radius: var(--rui-alert-border-radius);
3+
$alert-padding: var(--rui-alert-padding);
34
$alert-icon-size: var(--rui-icon-size-default);
45

56
$alert-types: (
Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
@import '../../../styles/settings/colors';
22
@import '../../../styles/settings/offsets';
33
@import '../../../styles/settings/typography';
4+
@import './theme';
45

6+
$alert-font-size: map-get($typography-size-values, 0);
57
$alert-line-height: 1.2;
6-
$alert-min-height: 30px;
7-
$alert-offset: map-get($offset-values, 1);
8+
$alert-min-height:
9+
calc(
10+
#{$alert-font-size} * #{$alert-line-height} + 2 * #{$alert-padding} + 2 * #{$alert-border-width}
11+
);
812
$alert-stripe-width: 5px;
913
$alert-message-font-weight: map-get($typography-font-weight-values, light);
1014
$alert-title-font-weight: map-get($typography-font-weight-values, bold);

src/lib/theme.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@
154154
// Alerts: common properties
155155
--rui-alert-border-width: var(--rui-border-width);
156156
--rui-alert-border-radius: var(--rui-border-radius);
157+
--rui-alert-padding: var(--rui-offset-1);
157158

158159
// Alerts: type: success
159160
--rui-alert-success-foreground-color: var(--rui-color-success);

0 commit comments

Comments
 (0)