Centralize path definitions for Fantom builds and move to .out (#52829)

Summary:
Pull Request resolved: #52829

Changelog: [internal]

Just a small refactor to move the definitions of output paths to a specific module. We'll add more to this in a latter diff.

Reviewed By: sammy-SC

Differential Revision: D78905645

fbshipit-source-id: 011e6cec13396301dad8e76400b6f2b9e13568f0

Author: rubennorte

.gitignore

@@ -170,6 +170,7 @@ fix_*.patch
 
 # Jest Integration
 /private/react-native-fantom/build/
+/private/react-native-fantom/.out/
 /private/react-native-fantom/tester/build/
 
 # [Experimental] Generated TS type definitions

private/react-native-fantom/runner/executables/hermesc.js

@@ -11,6 +11,7 @@
 import type {HermesVariant, SyncCommandResult} from '../utils';
 
 import {isCI} from '../EnvironmentOptions';
+import {NATIVE_BUILD_OUTPUT_PATH} from '../paths';
 import {
   getBuckModesForPlatform,
   getBuckOptionsForHermes,
@@ -19,7 +20,6 @@ import {
   runBuck2Sync,
   runCommandSync,
 } from '../utils';
-import {getNativeBuildOutputPath} from './utils';
 import fs from 'fs';
 import path from 'path';
 
@@ -33,7 +33,7 @@ function getHermesCompilerPath({
   hermesVariant,
 }: TesterOptions): string {
   return path.join(
-    getNativeBuildOutputPath(),
+    NATIVE_BUILD_OUTPUT_PATH,
     `hermesc-${(hermesVariant as string).toLowerCase()}-${isOptimizedMode ? 'opt' : 'dev'}`,
   );
 }

private/react-native-fantom/runner/executables/tester.js

@@ -11,6 +11,7 @@
 import type {AsyncCommandResult, HermesVariant} from '../utils';
 
 import {debugCpp, isCI} from '../EnvironmentOptions';
+import {NATIVE_BUILD_OUTPUT_PATH} from '../paths';
 import {
   getBuckModesForPlatform,
   getBuckOptionsForHermes,
@@ -19,7 +20,6 @@ import {
   runBuck2Sync,
   runCommand,
 } from '../utils';
-import {getNativeBuildOutputPath} from './utils';
 import fs from 'fs';
 import path from 'path';
 
@@ -36,7 +36,7 @@ function getFantomTesterPath({
   hermesVariant,
 }: TesterOptions): string {
   return path.join(
-    getNativeBuildOutputPath(),
+    NATIVE_BUILD_OUTPUT_PATH,
     `fantom-tester-${(hermesVariant as string).toLowerCase()}-${isOptimizedMode ? 'opt' : 'dev'}`,
   );
 }

private/react-native-fantom/runner/executables/utils.js

@@ -12,7 +12,7 @@ import {createBundle} from '../bundling';
 import {isCI} from '../EnvironmentOptions';
 import {build as buildHermesCompiler} from '../executables/hermesc';
 import {build as buildFantomTester} from '../executables/tester';
-import {getNativeBuildOutputPath} from '../executables/utils';
+import {NATIVE_BUILD_OUTPUT_PATH} from '../paths';
 import {HermesVariant} from '../utils';
 // $FlowExpectedError[untyped-import]
 import fs from 'fs';
@@ -39,10 +39,10 @@ async function tryOrLog(
 
 export default async function build(): Promise<void> {
   try {
-    fs.rmSync(getNativeBuildOutputPath(), {recursive: true});
+    fs.rmSync(NATIVE_BUILD_OUTPUT_PATH, {recursive: true});
   } catch {}
 
-  fs.mkdirSync(getNativeBuildOutputPath(), {recursive: true});
+  fs.mkdirSync(NATIVE_BUILD_OUTPUT_PATH, {recursive: true});
 
   if (isCI) {
     for (const isOptimizedMode of [false, true]) {

private/react-native-fantom/runner/global-setup/build.js

@@ -0,0 +1,29 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict-local
+ * @format
+ */
+
+import path from 'path';
+
+export const OUTPUT_PATH: string = path.resolve(__dirname, '..', '.out');
+export const JS_BUILD_OUTPUT_PATH: string = path.join(OUTPUT_PATH, 'js-builds');
+export const NATIVE_BUILD_OUTPUT_PATH: string = path.join(
+  OUTPUT_PATH,
+  'native-builds',
+);
+
+export function getTestBuildOutputPath(): string {
+  const fantomRunID = process.env.__FANTOM_RUN_ID__;
+  if (fantomRunID == null) {
+    throw new Error(
+      'Expected Fantom run ID to be set by global setup, but it was not (process.env.__FANTOM_RUN_ID__ is null)',
+    );
+  }
+
+  return path.join(JS_BUILD_OUTPUT_PATH, fantomRunID);
+}

private/react-native-fantom/runner/paths.js

@@ -27,6 +27,7 @@ import {run as runHermesCompiler} from './executables/hermesc';
 import {run as runFantomTester} from './executables/tester';
 import formatFantomConfig from './formatFantomConfig';
 import getFantomTestConfigs from './getFantomTestConfigs';
+import {getTestBuildOutputPath} from './paths';
 import {
   getInitialSnapshotData,
   updateSnapshotsAndGetJestSnapshotResult,
@@ -46,17 +47,8 @@ import nullthrows from 'nullthrows';
 import path from 'path';
 import readline from 'readline';
 
-const fantomRunID = process.env.__FANTOM_RUN_ID__;
-if (fantomRunID == null) {
-  throw new Error(
-    'Expected Fantom run ID to be set by global setup, but it was not (process.env.__FANTOM_RUN_ID__ is null)',
-  );
-}
-
-const BUILD_OUTPUT_ROOT = path.resolve(__dirname, '..', 'build', 'js');
-const BUILD_OUTPUT_PATH = path.join(BUILD_OUTPUT_ROOT, fantomRunID);
-
-fs.mkdirSync(BUILD_OUTPUT_PATH, {recursive: true});
+const TEST_BUILD_OUTPUT_PATH = getTestBuildOutputPath();
+fs.mkdirSync(TEST_BUILD_OUTPUT_PATH, {recursive: true});
 
 function buildError(
   failureDetail: FailureDetail,
@@ -276,9 +268,9 @@ module.exports = async function runTest(
     }
 
     const entrypointContents = entrypointTemplate({
-      testPath: `${path.relative(BUILD_OUTPUT_PATH, testPath)}`,
-      setupModulePath: `${path.relative(BUILD_OUTPUT_PATH, setupModulePath)}`,
-      featureFlagsModulePath: `${path.relative(BUILD_OUTPUT_PATH, featureFlagsModulePath)}`,
+      testPath: `${path.relative(TEST_BUILD_OUTPUT_PATH, testPath)}`,
+      setupModulePath: `${path.relative(TEST_BUILD_OUTPUT_PATH, setupModulePath)}`,
+      featureFlagsModulePath: `${path.relative(TEST_BUILD_OUTPUT_PATH, featureFlagsModulePath)}`,
       testConfig,
       snapshotConfig: {
         updateSnapshot: snapshotState._updateSnapshot,
@@ -287,7 +279,7 @@ module.exports = async function runTest(
     });
 
     const entrypointPath = path.join(
-      BUILD_OUTPUT_PATH,
+      TEST_BUILD_OUTPUT_PATH,
       `${Date.now()}-${path.basename(testPath)}`,
     );
     const testJSBundlePath = entrypointPath + '.bundle.js';