Skip to content

Commit 4b954e1

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Use relevant revision as base when updating mounted flag with branching enabled (#56446)
Summary: Pull Request resolved: #56446 Changelog: [GENERAL][FIXED] Uses relevant revision as base for mounted flag updates Similarly to the commit itself, which is already handled above, `updateMountedFlag` should be using relevant revision to compare the new tree. During react commits, it should compare to the react revision if it exists, and the main revision in all other cases. Reviewed By: rubennorte Differential Revision: D100800154 fbshipit-source-id: ee4f9441c598a4707db65fb6ea465245e8d8f8c1
1 parent fc331f3 commit 4b954e1

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • packages/react-native/ReactCommon/react/renderer/mounting

packages/react-native/ReactCommon/react/renderer/mounting/ShadowTree.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ CommitStatus ShadowTree::tryCommit(
425425
{
426426
std::scoped_lock dispatchLock(EventEmitter::DispatchMutex());
427427
updateMountedFlag(
428-
currentRevision_.rootShadowNode->getChildren(),
428+
oldRevision.rootShadowNode->getChildren(),
429429
newRootShadowNode->getChildren(),
430430
commitOptions.source);
431431
}

0 commit comments

Comments
 (0)