Support recording request initiator call stacks in NetworkHandler (#54050)

Summary:
Pull Request resolved: #54050

Changelog: [Internal]

A naive approach to keeping track of request initiators inside the `NetworkHandler` singleton for CDP reporting purposes:

1. Expose a new `recordRequestInitiatorStack` method.
2. Keep the CDP-formatted stack trace (as a `folly::dynamic`) in a map keyed by request ID.
3. Destructively consume the stack trace during `onRequestWillBeSent`.

Reviewed By: huntie

Differential Revision: D83754143

fbshipit-source-id: 4f5a335f2eed66a168f9d39a66c8af6ccee23d6f

Author: motiz88

packages/react-native/ReactCommon/jsinspector-modern/network/NetworkHandler.cpp

@@ -69,6 +69,8 @@ void NetworkHandler::onRequestWillBeSent(
   }
 
   double timestamp = getCurrentUnixTimestampSeconds();
+  std::optional<folly::dynamic> initiator;
+  initiator = consumeStoredRequestInitiator(requestId);
   auto params = cdp::network::RequestWillBeSentParams{
       .requestId = requestId,
       .loaderId = "",
@@ -79,7 +81,9 @@ void NetworkHandler::onRequestWillBeSent(
       // Unix epoch for both.
       .timestamp = timestamp,
       .wallTime = timestamp,
-      .initiator = folly::dynamic::object("type", "script"),
+      .initiator = initiator.has_value()
+          ? std::move(initiator.value())
+          : folly::dynamic::object("type", "script"),
       .redirectHasExtraInfo = redirectResponse.has_value(),
       .redirectResponse = redirectResponse,
   };
@@ -114,7 +118,7 @@ void NetworkHandler::onResponseReceived(
 
   auto resourceType = cdp::network::resourceTypeFromMimeType(response.mimeType);
   {
-    std::lock_guard<std::mutex> lock(resourceTypeMapMutex_);
+    std::lock_guard<std::mutex> lock(requestMetadataMutex_);
     resourceTypeMap_.emplace(requestId, resourceType);
   }
 
@@ -175,7 +179,7 @@ void NetworkHandler::onLoadingFailed(
   }
 
   {
-    std::lock_guard<std::mutex> lock(resourceTypeMapMutex_);
+    std::lock_guard<std::mutex> lock(requestMetadataMutex_);
     auto params = cdp::network::LoadingFailedParams{
         .requestId = requestId,
         .timestamp = getCurrentUnixTimestampSeconds(),
@@ -212,4 +216,30 @@ std::optional<std::tuple<std::string, bool>> NetworkHandler::getResponseBody(
       responseBody->data, responseBody->base64Encoded);
 }
 
+void NetworkHandler::recordRequestInitiatorStack(
+    const std::string& requestId,
+    folly::dynamic stackTrace) {
+  if (!isEnabledNoSync()) {
+    return;
+  }
+
+  std::lock_guard<std::mutex> lock(requestMetadataMutex_);
+  requestInitiatorById_.emplace(
+      requestId,
+      folly::dynamic::object("type", "script")("stack", std::move(stackTrace)));
+}
+
+std::optional<folly::dynamic> NetworkHandler::consumeStoredRequestInitiator(
+    const std::string& requestId) {
+  std::lock_guard<std::mutex> lock(requestMetadataMutex_);
+  auto it = requestInitiatorById_.find(requestId);
+  if (it == requestInitiatorById_.end()) {
+    return std::nullopt;
+  }
+  // Remove and return
+  auto result = std::move(it->second);
+  requestInitiatorById_.erase(it);
+  return result;
+}
+
 } // namespace facebook::react::jsinspector_modern

packages/react-native/ReactCommon/jsinspector-modern/network/NetworkHandler.h

@@ -124,6 +124,13 @@ class NetworkHandler {
   std::optional<std::tuple<std::string, bool>> getResponseBody(
       const std::string& requestId);
 
+  /**
+   * Associate the given stack trace with the given request ID.
+   */
+  void recordRequestInitiatorStack(
+      const std::string& requestId,
+      folly::dynamic stackTrace);
+
  private:
   NetworkHandler() = default;
   NetworkHandler(const NetworkHandler&) = delete;
@@ -136,10 +143,14 @@ class NetworkHandler {
     return enabled_.load(std::memory_order_relaxed);
   }
 
+  std::optional<folly::dynamic> consumeStoredRequestInitiator(
+      const std::string& requestId);
+
   FrontendChannel frontendChannel_;
 
   std::map<std::string, std::string> resourceTypeMap_{};
-  std::mutex resourceTypeMapMutex_{};
+  std::map<std::string, folly::dynamic> requestInitiatorById_{};
+  std::mutex requestMetadataMutex_{};
 
   BoundedRequestBuffer responseBodyBuffer_{};
   std::mutex requestBodyMutex_;