Don't crash on reload (#53590)

christophpurrer · facebook-github-bot · commit 5d65794ee4fa · 2025-09-03T19:01:15.000-07:00
Summary: Pull Request resolved: #53590 Changelog: [General][Fixed] ReactCxxPlatform] Don't crash on reload Reviewed By: shwanton Differential Revision: D81626640 fbshipit-source-id: 31016c67a1913a8be8578848e756e0447b802484
diff --git a/packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.cpp b/packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.cpp
@@ -533,7 +533,9 @@ std::unordered_set<SurfaceId> ReactHost::getRunningSurfaces() const noexcept {
 
 void ReactHost::runOnScheduler(
     std::function<void(Scheduler& scheduler)>&& task) const {
-  task(*scheduler_);
+  if (!isReloadingReactInstance_) {
+    task(*scheduler_);
+  }
 }
 
 void ReactHost::runOnRuntimeScheduler(

Original file line number	Diff line number	Diff line change
`@@ -533,7 +533,9 @@ std::unordered_set<SurfaceId> ReactHost::getRunningSurfaces() const noexcept {`
`533`	`533`
`534`	`534`	`void ReactHost::runOnScheduler(`
`535`	`535`	`std::function<void(Scheduler& scheduler)>&& task) const {`
`536`		`- task(*scheduler_);`
	`536`	`+ if (!isReloadingReactInstance_) {`
	`537`	`+ task(*scheduler_);`
	`538`	`+ }`
`537`	`539`	`}`
`538`	`540`
`539`	`541`	`void ReactHost::runOnRuntimeScheduler(`