Use == instead of EXPECT_EQ in testlib

avp · facebook-github-bot · commit b4a10f01fbb2 · 2025-07-28T19:14:54.000-07:00
Summary:
The `EXPECT_EQ` was leading to potentially ambiguous use of `&lt;&lt;` when
gtest tries to print information.

Changelog: [Internal]

Reviewed By: tsaichien

Differential Revision: D78823354

fbshipit-source-id: d26de07f02eb8bb53a4dec34b5fb302681bfbef8
diff --git a/packages/react-native/ReactCommon/jsi/jsi/test/testlib.cpp b/packages/react-native/ReactCommon/jsi/jsi/test/testlib.cpp
@@ -1877,7 +1877,9 @@ TEST_P(JSITest, CastInterface) {
   auto randomUuid = UUID{0xf2cd96cf, 0x455e, 0x42d9, 0x850a, 0x13e2cde59b8b};
   auto ptr = rd.castInterface(randomUuid);
 
-  EXPECT_EQ(ptr, nullptr);
+  // Use == instead of EXPECT_EQ to avoid ambiguous operator usage due to the
+  // type of 'ptr'.
+  EXPECT_TRUE(ptr == nullptr);
 }
 
 INSTANTIATE_TEST_CASE_P(

Original file line number	Diff line number	Diff line change
`@@ -1877,7 +1877,9 @@ TEST_P(JSITest, CastInterface) {`
`1877`	`1877`	`auto randomUuid = UUID{0xf2cd96cf, 0x455e, 0x42d9, 0x850a, 0x13e2cde59b8b};`
`1878`	`1878`	`auto ptr = rd.castInterface(randomUuid);`
`1879`	`1879`
`1880`		`- EXPECT_EQ(ptr, nullptr);`
	`1880`	`+ // Use == instead of EXPECT_EQ to avoid ambiguous operator usage due to the`
	`1881`	`+ // type of 'ptr'.`
	`1882`	`+ EXPECT_TRUE(ptr == nullptr);`
`1881`	`1883`	`}`
`1882`	`1884`
`1883`	`1885`	`INSTANTIATE_TEST_CASE_P(`