Don't hold windowDisplayMetrics

Author: zoontek

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -3283,13 +3283,12 @@ public abstract class com/facebook/react/uimanager/BaseViewManagerDelegate : com
 
 public final class com/facebook/react/uimanager/DisplayMetricsHolder {
 	public static final field INSTANCE Lcom/facebook/react/uimanager/DisplayMetricsHolder;
-	public static final fun getDisplayMetricsWritableMap (D)Lcom/facebook/react/bridge/WritableMap;
+	public static final fun getDisplayMetricsWritableMap (Landroid/util/DisplayMetrics;D)Lcom/facebook/react/bridge/WritableMap;
 	public static final fun getScreenDisplayMetrics ()Landroid/util/DisplayMetrics;
-	public static final fun getWindowDisplayMetrics ()Landroid/util/DisplayMetrics;
+	public static final fun getWindowDisplayMetrics (Landroid/content/Context;Landroid/app/Activity;)Landroid/util/DisplayMetrics;
 	public static final fun initDisplayMetrics (Landroid/content/Context;)V
 	public static final fun initDisplayMetricsIfNotInitialized (Landroid/content/Context;)V
 	public static final fun setScreenDisplayMetrics (Landroid/util/DisplayMetrics;)V
-	public static final fun setWindowDisplayMetrics (Landroid/util/DisplayMetrics;)V
 }
 
 public final class com/facebook/react/uimanager/FloatUtil {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java

@@ -14,6 +14,7 @@
 import static com.facebook.systrace.Systrace.TRACE_TAG_REACT;
 
 import android.annotation.SuppressLint;
+import android.app.Activity;
 import android.content.Context;
 import android.graphics.BlendMode;
 import android.graphics.Canvas;
@@ -1018,8 +1019,13 @@ private void checkForKeyboardEventsLegacy() {
           }
         }
       }
+
+      final ReactContext reactContext = getCurrentReactContext();
+      final Activity currentActivity =
+        reactContext != null ? reactContext.getCurrentActivity() : null;
+
       final int heightDiff =
-          DisplayMetricsHolder.getWindowDisplayMetrics().heightPixels
+          DisplayMetricsHolder.getWindowDisplayMetrics(getContext(), currentActivity).heightPixels
               - mVisibleViewArea.bottom
               + notchHeight;
 

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/deviceinfo/DeviceInfoModule.kt

@@ -15,6 +15,7 @@ import com.facebook.react.bridge.ReactSoftExceptionLogger
 import com.facebook.react.bridge.ReadableMap
 import com.facebook.react.module.annotations.ReactModule
 import com.facebook.react.uimanager.DisplayMetricsHolder.getDisplayMetricsWritableMap
+import com.facebook.react.uimanager.DisplayMetricsHolder.getWindowDisplayMetrics
 import com.facebook.react.uimanager.DisplayMetricsHolder.initDisplayMetricsIfNotInitialized
 import com.facebook.react.views.view.isEdgeToEdgeFeatureFlagOn
 
@@ -31,7 +32,9 @@ internal class DeviceInfoModule(reactContext: ReactApplicationContext) :
   }
 
   public override fun getTypedExportedConstants(): Map<String, Any> {
-    val displayMetrics = getDisplayMetricsWritableMap(fontScale.toDouble())
+    val windowDisplayMetrics =
+        getWindowDisplayMetrics(reactApplicationContext, reactApplicationContext.currentActivity)
+    val displayMetrics = getDisplayMetricsWritableMap(windowDisplayMetrics, fontScale.toDouble())
 
     // Cache the initial dimensions for later comparison in emitUpdateDimensionsEvent
     previousDisplayMetrics = displayMetrics.copy()
@@ -58,7 +61,13 @@ internal class DeviceInfoModule(reactContext: ReactApplicationContext) :
     reactApplicationContext.let { context ->
       if (context.hasActiveReactInstance()) {
         // Don't emit an event to JS if the dimensions haven't changed
-        val displayMetrics = getDisplayMetricsWritableMap(fontScale.toDouble())
+        val windowDisplayMetrics =
+            getWindowDisplayMetrics(
+                reactApplicationContext,
+                reactApplicationContext.currentActivity,
+            )
+        val displayMetrics =
+            getDisplayMetricsWritableMap(windowDisplayMetrics, fontScale.toDouble())
         if (previousDisplayMetrics == null) {
           previousDisplayMetrics = displayMetrics.copy()
         } else if (displayMetrics != previousDisplayMetrics) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/DisplayMetricsHolder.kt

@@ -14,9 +14,11 @@ import android.util.DisplayMetrics
 import android.view.WindowManager
 import androidx.core.view.ViewCompat
 import androidx.core.view.WindowInsetsCompat
+import androidx.window.layout.WindowMetricsCalculator
 import com.facebook.react.bridge.WritableMap
 import com.facebook.react.bridge.WritableNativeMap
 import com.facebook.react.uimanager.PixelUtil.pxToDp
+import com.facebook.react.views.view.isEdgeToEdgeFeatureFlagOn
 
 /**
  * Holds an instance of the current DisplayMetrics so we don't have to thread it through all the
@@ -26,19 +28,25 @@ public object DisplayMetricsHolder {
   private const val INITIALIZATION_MISSING_MESSAGE =
       "DisplayMetricsHolder must be initialized with initDisplayMetricsIfNotInitialized or initDisplayMetrics"
 
-  @JvmStatic private var windowDisplayMetrics: DisplayMetrics? = null
   @JvmStatic private var screenDisplayMetrics: DisplayMetrics? = null
 
   /** The metrics of the window associated to the Context used to initialize ReactNative */
   @JvmStatic
-  public fun getWindowDisplayMetrics(): DisplayMetrics {
-    checkNotNull(windowDisplayMetrics) { INITIALIZATION_MISSING_MESSAGE }
-    return windowDisplayMetrics as DisplayMetrics
-  }
+  public fun getWindowDisplayMetrics(context: Context, activity: Activity?): DisplayMetrics {
+    val displayMetrics = context.resources.displayMetrics
+    val windowDisplayMetrics = DisplayMetrics()
+    windowDisplayMetrics.setTo(displayMetrics)
+
+    if (isEdgeToEdgeFeatureFlagOn) {
+      activity?.let { activity ->
+        WindowMetricsCalculator.getOrCreate().computeCurrentWindowMetrics(activity).let {
+          windowDisplayMetrics.widthPixels = it.bounds.width()
+          windowDisplayMetrics.heightPixels = it.bounds.height()
+        }
+      }
+    }
 
-  @JvmStatic
-  public fun setWindowDisplayMetrics(displayMetrics: DisplayMetrics?) {
-    windowDisplayMetrics = displayMetrics
+    return windowDisplayMetrics
   }
 
   /** Screen metrics returns the metrics of the default screen on the device. */
@@ -62,11 +70,10 @@ public object DisplayMetricsHolder {
   }
 
   @JvmStatic
-  @SuppressLint("DeprecatedMethod") // for Andriod Lint
+  @SuppressLint("DeprecatedMethod") // for Android Lint
   @Suppress("DEPRECATION") // for Kotlin compiler
   public fun initDisplayMetrics(context: Context) {
     val displayMetrics = context.resources.displayMetrics
-    windowDisplayMetrics = displayMetrics
     val screenDisplayMetrics = DisplayMetrics()
     screenDisplayMetrics.setTo(displayMetrics)
     try {
@@ -85,14 +92,16 @@ public object DisplayMetricsHolder {
   }
 
   @JvmStatic
-  public fun getDisplayMetricsWritableMap(fontScale: Double): WritableMap {
-    checkNotNull(windowDisplayMetrics) { INITIALIZATION_MISSING_MESSAGE }
+  public fun getDisplayMetricsWritableMap(
+      windowDisplayMetrics: DisplayMetrics,
+      fontScale: Double,
+  ): WritableMap {
     checkNotNull(screenDisplayMetrics) { INITIALIZATION_MISSING_MESSAGE }
 
     return WritableNativeMap().apply {
       putMap(
           "windowPhysicalPixels",
-          getPhysicalPixelsWritableMap(windowDisplayMetrics as DisplayMetrics, fontScale),
+          getPhysicalPixelsWritableMap(windowDisplayMetrics, fontScale),
       )
       putMap(
           "screenPhysicalPixels",

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/deviceinfo/DeviceInfoModuleTest.kt

@@ -9,6 +9,7 @@
 
 package com.facebook.react.modules.deviceinfo
 
+import android.util.DisplayMetrics
 import com.facebook.react.bridge.BridgeReactContext
 import com.facebook.react.bridge.JavaOnlyMap
 import com.facebook.react.bridge.ReactContext
@@ -111,8 +112,15 @@ class DeviceInfoModuleTest : TestCase() {
   }
 
   private fun givenDisplayMetricsHolderContains(fakeDisplayMetrics: WritableMap?) {
+    val windowDisplayMetrics = DisplayMetrics()
+
+    displayMetricsHolder
+        .`when`<DisplayMetrics> { DisplayMetricsHolder.getWindowDisplayMetrics(reactContext, null) }
+        .thenAnswer { windowDisplayMetrics }
     displayMetricsHolder
-        .`when`<WritableMap> { DisplayMetricsHolder.getDisplayMetricsWritableMap(1.0) }
+        .`when`<WritableMap> {
+          DisplayMetricsHolder.getDisplayMetricsWritableMap(windowDisplayMetrics, 1.0)
+        }
         .thenAnswer { fakeDisplayMetrics }
   }
 

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/DisplayMetricsHolderTest.kt

@@ -55,33 +55,19 @@ class DisplayMetricsHolderTest {
   fun setUp() {
     context = RuntimeEnvironment.getApplication()
     displayMetrics = context.resources.displayMetrics
-    DisplayMetricsHolder.setWindowDisplayMetrics(null)
     DisplayMetricsHolder.setScreenDisplayMetrics(null)
   }
 
   @After
   fun tearDown() {
-    DisplayMetricsHolder.setWindowDisplayMetrics(null)
     DisplayMetricsHolder.setScreenDisplayMetrics(null)
   }
 
-  @Test(expected = IllegalStateException::class)
-  fun getWindowDisplayMetrics_failsIfDisplayMetricsIsNotInitialized() {
-    DisplayMetricsHolder.getWindowDisplayMetrics()
-  }
-
   @Test(expected = IllegalStateException::class)
   fun getScreenDisplayMetrics_failsIfDisplayMetricsIsNotInitialized() {
     DisplayMetricsHolder.getScreenDisplayMetrics()
   }
 
-  @Test
-  fun setAndGetWindowDisplayMetrics_returnsSetValue() {
-    DisplayMetricsHolder.setWindowDisplayMetrics(displayMetrics)
-    val result = DisplayMetricsHolder.getWindowDisplayMetrics()
-    assertThat(result).isEqualTo(displayMetrics)
-  }
-
   @Test
   fun setAndGetScreenDisplayMetrics_returnsSetValue() {
     DisplayMetricsHolder.setScreenDisplayMetrics(displayMetrics)
@@ -92,33 +78,32 @@ class DisplayMetricsHolderTest {
   @Test
   fun initDisplayMetrics_setsMetrics() {
     DisplayMetricsHolder.initDisplayMetrics(context)
-    assertThat(DisplayMetricsHolder.getWindowDisplayMetrics()).isNotNull()
     assertThat(DisplayMetricsHolder.getScreenDisplayMetrics()).isNotNull()
   }
 
   @Test
   fun initDisplayMetricsIfNotInitialized_onlyInitializesOnce() {
     DisplayMetricsHolder.initDisplayMetricsIfNotInitialized(context)
-    val firstWindow = DisplayMetricsHolder.getWindowDisplayMetrics()
     val firstScreen = DisplayMetricsHolder.getScreenDisplayMetrics()
     // Should not reinitialize
     DisplayMetricsHolder.initDisplayMetricsIfNotInitialized(context)
-    val secondWindow = DisplayMetricsHolder.getWindowDisplayMetrics()
     val secondScreen = DisplayMetricsHolder.getScreenDisplayMetrics()
-    assertThat(secondWindow).isEqualTo(firstWindow)
     assertThat(secondScreen).isEqualTo(firstScreen)
   }
 
   @Test(expected = IllegalStateException::class)
   fun getDisplayMetricsWritableMap_failsIfNotInitialized() {
-    DisplayMetricsHolder.getDisplayMetricsWritableMap(1.0)
+    val windowDisplayMetrics = DisplayMetrics()
+    DisplayMetricsHolder.getDisplayMetricsWritableMap(windowDisplayMetrics, 1.0)
   }
 
   @Test
   fun getDisplayMetricsWritableMap_returnsCorrectMap() {
     // Use the official initialization method to ensure both metrics are set
     DisplayMetricsHolder.initDisplayMetrics(context)
-    val map: WritableMap = DisplayMetricsHolder.getDisplayMetricsWritableMap(1.0)
+    val windowDisplayMetrics = DisplayMetrics()
+    val map: WritableMap =
+        DisplayMetricsHolder.getDisplayMetricsWritableMap(windowDisplayMetrics, 1.0)
     assertThat(map.hasKey("windowPhysicalPixels")).isTrue()
     assertThat(map.hasKey("screenPhysicalPixels")).isTrue()
     val windowMap = map.getMap("windowPhysicalPixels")
@@ -204,7 +189,6 @@ class DisplayMetricsHolderTest {
     DisplayMetricsHolder.initDisplayMetrics(mockContext)
 
     // Metrics should still be set from resource display metrics
-    assertThat(DisplayMetricsHolder.getWindowDisplayMetrics()).isNotNull()
     assertThat(DisplayMetricsHolder.getScreenDisplayMetrics()).isNotNull()
   }
 }