Skip to content

Commit c37f3ed

Browse files
cortinicofacebook-github-bot
authored andcommitted
Remove unnecessary ReactNoCrashBridgeNotAllowedSoftException (#52987)
Summary: Pull Request resolved: #52987 This class is unnecessary. Is also public for no real reason. Instead we should use `ReactNoCrashSoftException` directly. I'm not marking this as breaking as users hsould not be catching this class. Changelog: [Internal] [Changed] - Reviewed By: mdvacca Differential Revision: D79451567 fbshipit-source-id: 4d6f45b3006c79969fcf141002d34a72bf88901a
1 parent 2f46a49 commit c37f3ed

3 files changed

Lines changed: 1 addition & 37 deletions

File tree

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1309,12 +1309,6 @@ public abstract interface annotation class com/facebook/react/bridge/ReactMethod
13091309
public abstract interface class com/facebook/react/bridge/ReactModuleWithSpec {
13101310
}
13111311

1312-
public final class com/facebook/react/bridge/ReactNoCrashBridgeNotAllowedSoftException : com/facebook/react/bridge/ReactNoCrashSoftException {
1313-
public fun <init> (Ljava/lang/String;)V
1314-
public fun <init> (Ljava/lang/String;Ljava/lang/Throwable;)V
1315-
public fun <init> (Ljava/lang/Throwable;)V
1316-
}
1317-
13181312
public class com/facebook/react/bridge/ReactNoCrashSoftException : java/lang/RuntimeException {
13191313
public fun <init> (Ljava/lang/String;)V
13201314
public fun <init> (Ljava/lang/String;Ljava/lang/Throwable;)V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactNoCrashBridgeNotAllowedSoftException.kt

Lines changed: 0 additions & 29 deletions
This file was deleted.

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import com.facebook.react.bridge.NativeModule
2929
import com.facebook.react.bridge.ReactContext
3030
import com.facebook.react.bridge.ReactMarker
3131
import com.facebook.react.bridge.ReactMarkerConstants
32-
import com.facebook.react.bridge.ReactNoCrashBridgeNotAllowedSoftException
3332
import com.facebook.react.bridge.ReactNoCrashSoftException
3433
import com.facebook.react.bridge.ReactSoftExceptionLogger
3534
import com.facebook.react.bridge.RuntimeExecutor
@@ -529,7 +528,7 @@ public class ReactHostImpl(
529528
nativeModuleInterface == UIManagerModule::class.java) {
530529
ReactSoftExceptionLogger.logSoftExceptionVerbose(
531530
TAG,
532-
ReactNoCrashBridgeNotAllowedSoftException(
531+
ReactNoCrashSoftException(
533532
"getNativeModule(UIManagerModule.class) cannot be called when the bridge is disabled"))
534533
}
535534

0 commit comments

Comments
 (0)