Commit c8263ef
Fix asyncArrayBufferBorrowNativeBackedTest unconditional skip on Hermes
Summary:
## Changelog:
[General][Fixed] Fix asyncArrayBufferBorrowNativeBackedTest unconditional skip on Hermes
On runtimes that don't implement `tryGetMutableBuffer` (e.g. Hermes / Android-32bit), `asyncArrayBufferBorrowNativeBackedTest` always called `GTEST_SKIP()`, which surfaced as a perpetually-skipped test in CI.
Replace the skip with `EXPECT_JSI_THROW(AsyncArrayBuffer::borrow(...))`. On runtimes without `tryGetMutableBuffer`, `borrow` is documented to throw because there is no native `MutableBuffer` to hand back, so this is the meaningful behavior to assert. On runtimes that do implement `tryGetMutableBuffer`, the existing zero-copy assertions are unchanged.
___
Differential Revision: D1086570731 parent dd5c383 commit c8263ef
1 file changed
Lines changed: 5 additions & 4 deletions
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
843 | 843 | | |
844 | 844 | | |
845 | 845 | | |
846 | | - | |
847 | | - | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
848 | 849 | | |
849 | 850 | | |
850 | 851 | | |
851 | 852 | | |
852 | 853 | | |
853 | | - | |
854 | | - | |
| 854 | + | |
| 855 | + | |
855 | 856 | | |
856 | 857 | | |
857 | 858 | | |
| |||
0 commit comments