Skip to content

Commit cca7207

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Include renderer core via its umbrella header in DOM.h (#59107)
Summary: Pull Request resolved: #59107 `DOM.h` is a "for frameworks" header but included `<react/renderer/core/ShadowNode.h>` directly. That header is in the public tier, so its `UmbrellaGuard` hard-errors when consumers opt into the strict API, and `RN_ALLOW_FRAMEWORKS` does not suppress it. Include the module umbrella `<React/RendererCore.h>` instead, which re-exports `ShadowNode.h`. `RootShadowNode.h` stays as a direct include: it is itself a "for frameworks" header and its module has no public umbrella. Changelog: [Internal] ___ landed-with-radar-review Differential Revision: D125435350 fbshipit-source-id: ca0dc430d392f57097e03cd6e59d6ea0867dfe2a
1 parent 72885c1 commit cca7207

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • packages/react-native/ReactCommon/react/renderer/dom

‎packages/react-native/ReactCommon/react/renderer/dom/DOM.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12+
#include <React/RendererCore.h>
1213
#include <react/renderer/components/root/RootShadowNode.h>
13-
#include <react/renderer/core/ShadowNode.h>
1414
#include <cstdint>
1515
#include <string>
1616
#include <vector>

0 commit comments

Comments
 (0)