Skip to content

Commit f2a6db9

Browse files
alanjhughesmeta-codesync[bot]
authored andcommitted
Export jserrorhandler headers in the reactnative prefab (#57608)
Summary: Regression from #57236 which moved ErrorUtils into `jserrorhandler`. It didn't add `jserrorhandler` to the Android prefab header export list in `build.gradle.kts`. The Android prefab's header export is maintained separately from the CMake link graph, so the reactnative prefab module still ships cxxreact/ErrorUtils.h while never publishing the jserrorhandler/ErrorUtils.h it now includes. Any external consumer building against the react-android prefab fails. We caught this in our nightly tests. ## Changelog: [ANDROID] [FIXED] - Export `jserrorhandler` headers in the `reactnative` prefab so external consumers of cxxreact/ErrorUtils.h can build. Pull Request resolved: #57608 Test Plan: Built the prefab headers and confirmed jserrorhandler/ErrorUtils.h is now published to the reactnative module: ``` ./gradlew :packages:react-native:ReactAndroid:preparePrefab find packages/react-native/ReactAndroid/build -path '*reactnative*jserrorhandler/ErrorUtils.h' # → .../prefab-headers/reactnative/jserrorhandler/ErrorUtils.h ``` Reviewed By: cipolleschi Differential Revision: D112798900 Pulled By: cortinico fbshipit-source-id: 17f4511f095afac67358563ac78c2cbf8da736cd
1 parent 4a66207 commit f2a6db9

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

packages/react-native/ReactAndroid/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,8 @@ val preparePrefab by
215215
Pair(File(buildDir, "third-party-ndk/glog/exported/").absolutePath, ""),
216216
Pair("../ReactCommon/callinvoker/", ""),
217217
Pair("../ReactCommon/cxxreact/", "cxxreact/"),
218+
// Exported because the public cxxreact/ErrorUtils.h includes it
219+
Pair("../ReactCommon/jserrorhandler/", "jserrorhandler/"),
218220
Pair("../ReactCommon/react/bridging/", "react/bridging/"),
219221
Pair("../ReactCommon/react/nativemodule/core/", ""),
220222
Pair("../ReactCommon/react/nativemodule/core/platform/android/", ""),

0 commit comments

Comments
 (0)